Missing character from mergetool removed

Drastic change of user-defined pointer type notation, and addition of support tools for casting between user-defined pointer types

## What is the new feature
Add a formatter for CMake files. And CI task for CMake formatting is also added.

## How is it implemented
We use the opensource tool https://github.com/cheshirekow/cmake_format

 for formatting.

Approved-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: feature

Roland Wirth authored 11 months ago and Yen-Chen Chen committed 11 months ago

String lists grow dynamically, removing the need for preallocated arrays. This simplifies
handling of large variable groups in the icon initialization phase.

The output lists of `add_to_list` are now `ALLOCATABLE`. They may be passed an unallocated
argument, which is treated like an empty list and allocated using the new `new_list`
subroutine. That subroutine initially allocates space for 8 strings. Every time the list
needs to grow, the allocated size doubles. This ensures constant amortized runtime for
adding to the list. No provisions are made for shrinking the list size, because they are
usually short-lived.

The tests for `add_to_list` are adapted for the new interface, checking list expansion.
A new test for `new_list` is added.

Approved-by: Yen-Chen Chen <yen-chen.chen@kit.edu>
Merged-by: Yen-Chen Chen <yen-chen.chen@kit.edu>
Changelog: feature

## What is the bug
`mo_fortran_tools` was updated during the release preparation MR.

Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: bugfix

## What is the new feature
Improve README.

Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: feature

## What is the bug
FortUTF did not return correct error code for failed test.
## How do you fix it
[This PR(merged)](https://github.com/artemis-beta/FortUTF/pull/22

) fixed the problem.

Approved-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: bugfix

Daniel Hupp authored 1 year ago and Yen-Chen Chen committed 1 year ago

## What is the new feature
This PR adds a new module for random number generations. It contains a parallelization uniform random number generator and a normal random number generator.
## How is it implemented
The uniform random number generator uses the Lehmer random number generator.
The normal random number generator uses a Box-Mueller transform using the uniform random number generator.

Approved-by: Yen-Chen Chen <yen-chen.chen@kit.edu>
Merged-by: Yen-Chen Chen <yen-chen.chen@kit.edu>
Changelog: feature

<!--
ICON
## What is the bug
LUMI does not have `OpenACC_C` and the BB fails because we are checking `OpenACC` for both `C` and `Fortran`. This MR fixes `lumi_gpu` BB.
## How do you fix it
Only check if `OpenACC_Fortran` is found.

Approved-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: bugfix

## What is the new feature
Add a typo check pipeline.
## How is it implemented
Use https://github.com/crate-ci/typos



Approved-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: feature

## What is the new feature
Make `lacc` arguments mandatory. This MR closes #17



Approved-by: Marek Jacob <1129-b380572@users.noreply.gitlab.dkrz.de>
Merged-by: Yen-Chen Chen <yen-chen.chen@kit.edu>
Changelog: bugfix

## What is the bug
Fix a test for the if_associated subroutine.
## How do you fix it
The false test did not pop up because of a bug in FortUTF. See #18



Approved-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: bugfix

## What is the bug
The accuracy of the expression evaluation code was falsely downscaled in the code.
## How do you fix it
The false test did not pop up because of a bug in FortUTF. See #18



Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: bugfix

## What is the new feature
Add tests
## How is it implemented
Add tests in `mo_expression` and the test coverage badge has officially turned yellow. 



Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: feature

Jonas Jucker authored 1 year ago and Yen-Chen Chen committed 1 year ago

New instructions for the merge request workflow.

Approved-by: Yen-Chen Chen <yen-chen.chen@kit.edu>
Merged-by: Yen-Chen Chen <yen-chen.chen@kit.edu>
Changelog: other

## What is the bug
Fix a bug in unit test ([here](!79 (diffs))

) and improve code coverage
## How do you fix it
The code coverage is improved to 100% for `mo_util_sort`, and new tests with random values are added.

Approved-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: bugfix

<!--
ICON

---------------------------------------------------------------
Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
Contact information: icon-model.org

See AUTHORS.TXT for a list of authors
See LICENSES/ for license information
SPDX-License-Identifier: CC0-1.0
---------------------------------------------------------------
-->

## What is the new feature
Add OpenACC beautifier
## How is it implemented
The OpenACC beautifier used in icon [here](https://gitlab.dkrz.de/icon/icon-mpim/-/blob/master/.gitlab-ci.yml?ref_type=heads#L21-L55

)

## Mandatory steps before review
- [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
- [x] New feature is covered by additional unit tests
- [x] Mark the merge request as ready by removing `Draft:`

## Mandatory steps before merge
- [x] Test coverage does not decrease
- [x] Reviewed by a maintainer
- [x] Incorporate review suggestions
- [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)

**You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**

Co-authored-by: Marek Jacob <1129-b380572@users.noreply.gitlab.dkrz.de>
Approved-by: Marek Jacob <1129-b380572@users.noreply.gitlab.dkrz.de>
Merged-by: Yen-Chen Chen <yen-chen.chen@kit.edu>
Changelog: feature

<!--
ICON

---------------------------------------------------------------
Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
Contact information: icon-model.org

See AUTHORS.TXT for a list of authors
See LICENSES/ for license information
SPDX-License-Identifier: CC0-1.0
---------------------------------------------------------------
-->

## What is the bug
The way of type conversion [here](https://gitlab.dkrz.de/icon-libraries/libfortran-support/-/blame/55913610ae02141850eb92c2ccc3f58759344646/src/mo_expression.F90?page=2#L1073

) is not suggested.
## How do you fix it
Convert types specifically. 

## How urgent is the bugfix
- [x] I need it as soon as possible
- [ ] I can wait for a couple of days
- [ ] None of my current codes is directly affected

## Mandatory steps before review
- [ ] Gitlab CI passes _(Hint: use `make format` for linting)_ 
- [x] Bugfix is covered by additional unit tests
- [x] Mark the merge request as ready by removing `Draft:`

## Mandatory steps before merge
- [ ] Test coverage does not decrease
- [ ] Reviewed by a maintainer
- [ ] Incorporate review suggestions
- [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)

**You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**

Co-authored-by: Marek Jacob <1129-b380572@users.noreply.gitlab.dkrz.de>
Approved-by: Marek Jacob <1129-b380572@users.noreply.gitlab.dkrz.de>
Merged-by: Yen-Chen Chen <yen-chen.chen@kit.edu>
Changelog: bugfix

<!--
ICON

---------------------------------------------------------------
Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
Contact information: icon-model.org

See AUTHORS.TXT for a list of authors
See LICENSES/ for license information
SPDX-License-Identifier: CC0-1.0
---------------------------------------------------------------
-->

## What is the bug
Tests in for loop are all the same.
## How do you fix it


## How urgent is the bugfix
- [ ] I need it as soon as possible
- [x] I can wait for a couple of days
- [ ] None of my current codes is directly affected

## Mandatory steps before review
- [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
- [x] Bugfix is covered by additional unit tests
- [x] Mark the merge request as ready by removing `Draft:`

## Mandatory steps before merge
- [x] Test coverage does not decrease
- [ ] Reviewed by a maintainer
- [ ] Incorporate review suggestions
- [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)

**You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**

Approved-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Merged-by: Jonas Jucker <jonas.jucker@env.ethz.ch>
Changelog: bugfix

<!--
ICON

---------------------------------------------------------------
Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
Contact information: icon-model.org

See AUTHORS.TXT for a list of authors
See LICENSES/ for license information
SPDX-License-Identifier: CC0-1.0
---------------------------------------------------------------
-->

## What is the new feature
Improve OpenACC configuration
## How is it implemented
This MR follows the configuration originally set up in the `math-support` library. See [here](https://gitlab.dkrz.de/icon-libraries/libmath-support/-/blob/6ad1577a20bbae01be6050bdb8263f39653cd348/cmake/check_macro.cmake) for the reference.  
~~This MR waits for !69

 to be merged first.~~

## Mandatory steps before review
- [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
- [x] New feature is covered by additional unit tests
- [x] Mark the merge request as ready by removing `Draft:`

## Mandatory steps before merge
- [x] Test coverage does not decrease
- [x] Reviewed by a maintainer
- [x] Incorporate review suggestions
- [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)

**You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**

Approved-by: Pradipta Samanta <samanta@dkrz.de>
Merged-by: Yen-Chen Chen <yen-chen.chen@kit.edu>
Changelog: feature