util_string: dynamically allocate and expand string lists

String lists grow dynamically, removing the need for preallocated arrays. This simplifies handling of large variable groups in the icon initialization phase.

The output lists of add_to_list are now ALLOCATABLE. They may be passed an unallocated argument, which is treated like an empty list and allocated using the new new_list subroutine. That subroutine initially allocates space for 8 strings. Every time the list needs to grow, the allocated size doubles. This ensures constant amortized runtime for adding to the list. No provisions are made for shrinking the list size, because they are usually short-lived.

The tests for add_to_list are adapted for the new interface, checking list expansion. A new test for new_list is added.

added 1 commit

• 69eeef0d - fshi^H^H^Hprettify

Compare with previous version

added 7 commits

• 69eeef0d...1651516a - 3 commits from branch master
• 9724841a - dynamically allocate and expand string lists
• 7c18e0f4 - util_string: remove unused variable
• 5351284c - test_util_string: add unit test for new_list and expansion test for add_to_list
• 4ab43c97 - fshi^H^H^Hprettify

Compare with previous version

added 1 commit

• 49b22e7e - code style

Compare with previous version

marked this merge request as ready

marked the checklist item Gitlab CI passes (Hint: use make format for linting) as completed

marked the checklist item New feature is covered by additional unit tests as completed

marked the checklist item Mark the merge request as ready by removing Draft: as completed

@b381588 Hi. Is this MR ready for review?

added ready for review label

assigned to @b381588

Some minor changes are required for the testing. Otherwise LGTM. Thanks for writing the unit tests.

requested review from @b382190

added 1 commit

• 7b7ad6a4 - test_util_string: fix test tags, cover untested line in add_to_list_1

Compare with previous version

marked the checklist item Reviewed by a maintainer as completed

marked the checklist item Incorporate review suggestions as completed

marked the checklist item Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain as completed

marked the checklist item Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) as completed

changed the description

approved this merge request