Skip to content
Snippets Groups Projects
Mikael Stellio's avatar
deleted branch add_contribution_guide at icon-libraries / libfortran-support
Mikael Stellio's avatar
Mikael Stellio's avatar
accepted merge request !116 "Add contribution guide" at icon-libraries / libfortran-support
Mikael Stellio's avatar
approved merge request !116 "Add contribution guide" at icon-libraries / libfortran-support
Mikael Stellio's avatar
commented on merge request !116 "Add contribution guide" at icon-libraries / libfortran-support

@b382190 @k202170 @k202204 @m300369 FYI: If there are no more comments, I will merge this MR this evening.

Dylan Kierans's avatar
commented on merge request !116 "Add contribution guide" at icon-libraries / libfortran-support

Sure. I think the MR template problem is something people only have to learn once. For example developers coming from icon-mpim repo are now more l...

Yen-Chen Chen's avatar
commented on merge request !116 "Add contribution guide" at icon-libraries / libfortran-support

Maybe not. People should have read the contribution guidelines before knowing that they should use the MR template....

Dylan Kierans's avatar
commented on merge request !116 "Add contribution guide" at icon-libraries / libfortran-support

Do you want to include an [] I have read the contribution guidelines in the MR+Issue templates?

Mikael Stellio's avatar
commented on merge request !116 "Add contribution guide" at icon-libraries / libfortran-support

Sure 👍

Yen-Chen Chen's avatar
commented on merge request !116 "Add contribution guide" at icon-libraries / libfortran-support

@b382090 Please keep this MR open for a few days for the others to take a look.

Yen-Chen Chen's avatar
pushed to branch add_contribution_guide at icon-libraries / libfortran-support
Yen-Chen Chen's avatar
pushed to branch add_contribution_guide at icon-libraries / libfortran-support
Mikael Stellio's avatar
commented on merge request !116 "Add contribution guide" at icon-libraries / libfortran-support

@b382190 Looks good to me, thanks a lot for adding this, it also served as a good source of infos for me.

Mikael Stellio's avatar
commented on merge request !116 "Add contribution guide" at icon-libraries / libfortran-support
6. Check whether you are listed in the `AUTHORS.txt` list. If not, add yourself in the alphabetic order. Your name will be included when your merge...
Yen-Chen Chen's avatar
pushed to branch add_contribution_guide at icon-libraries / libfortran-support
Yen-Chen Chen's avatar
commented on merge request !116 "Add contribution guide" at icon-libraries / libfortran-support
Yen-Chen Chen's avatar
pushed to branch add_contribution_guide at icon-libraries / libfortran-support
Yen-Chen Chen's avatar
pushed to branch add_contribution_guide at icon-libraries / libfortran-support
Mikael Stellio's avatar
deleted branch improve_changelog at icon-libraries / libfortran-support
Mikael Stellio's avatar
  • 169143ef · Enable Changelog automation for non-latest commits (icon-libraries/...