- Apr 04, 2024
-
-
Yen-Chen Chen authored
## What is the bug Fix a test for the if_associated subroutine. ## How do you fix it The false test did not pop up because of a bug in FortUTF. See #18 Approved-by:
Jonas Jucker <jonas.jucker@env.ethz.ch> Merged-by:
Jonas Jucker <jonas.jucker@env.ethz.ch> Changelog: bugfix
-
- Mar 04, 2024
-
-
Yen-Chen Chen authored
<!-- ICON --------------------------------------------------------------- Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss Contact information: icon-model.org See AUTHORS.TXT for a list of authors See LICENSES/ for license information SPDX-License-Identifier: CC0-1.0 --------------------------------------------------------------- --> ## What is the new feature _Please describe your feature in a couple of words._ ## How is it implemented _Describe important implementation details of the feature._ ## Mandatory steps before review - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ - [x] New feature is covered by additional unit tests - [x] Mark the merge request as ready by removing `Draft:` ## Mandatory steps before merge - [x] Test coverage does not decrease - [x] Reviewed by a maintainer - [x] Incorporate review suggestions - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!** Approved-by:
Jonas Jucker <jonas.jucker@env.ethz.ch> Merged-by:
Jonas Jucker <jonas.jucker@env.ethz.ch> Changelog: other
-
- Feb 23, 2024
-
-
Yen-Chen Chen authored
<!-- ICON --------------------------------------------------------------- Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss Contact information: icon-model.org See AUTHORS.TXT for a list of authors See LICENSES/ for license information SPDX-License-Identifier: CC0-1.0 --------------------------------------------------------------- --> ## What is the new feature This MR makes sure that the new version with OpenACC feature can be properly merged back to `icon-mpim` ## How is it implemented See MR in icon-mpim for BuildBot results. All BuildBots must pass. - Doxygen-style comments are removed to following the ICON style guide - Intent specifiers are manually capitalized. This is an open issue for `fprettify`. See [here](https://github.com/pseewald/fprettify/issues/108 ) - [x] Put back missing subroutines ## Mandatory steps before review - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ - [x] New feature is covered by additional unit tests - [x] Mark the merge request as ready by removing `Draft:` ## Mandatory steps before merge - [x] Test coverage does not decrease - [x] Reviewed by a maintainer - [x] Incorporate review suggestions - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!** Approved-by:
Jonas Jucker <jonas.jucker@env.ethz.ch> Merged-by:
Yen-Chen Chen <yen-chen.chen@kit.edu> Changelog: feature
-
- Jan 29, 2024
-
-
Yen-Chen Chen authored
<!-- ICON --------------------------------------------------------------- Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss Contact information: icon-model.org See AUTHORS.TXT for a list of authors See LICENSES/ for license information SPDX-License-Identifier: CC0-1.0 --------------------------------------------------------------- --> ## What is the new feature _Please describe your feature in a couple of words._ ## How is it implemented This branch is a temporary solution to the requirement of `mo_fortran_tools` required for the math libraries. The adapted version of `mo_fortran_tools` removes the `i_am_accel_node` variable, therefore can only either not use OpenACC or use OpenACC for all nodes. - [x] This branch uses the style from !17. Merge !17 first. ## Mandatory steps before review - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ - [x] New feature is covered by additional unit tests - [x] Mark the merge request as ready by removing `Draft:` ## Mandatory steps before merge - [x] Test coverage does not decrease - [x] Reviewed by a maintainer - [x] Incorporate review suggestions - [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!** Co-authored-by:
yanjen <yanjen224@gmail.com> Co-authored-by:
Jonas Jucker <jonas.jucker@env.ethz.ch> Co-authored-by:
Pradipta Samanta <samanta@dkrz.de> Approved-by:
Jonas Jucker <jonas.jucker@env.ethz.ch> Merged-by:
Yen-Chen Chen <yen-chen.chen@kit.edu> Changelog: feature
-