Update extension
This branch resolves #4 (closed).
Fortran files with .F90
extensions will be processed automatically. This branch changes the extensions of the Fortran files so that preprocessing doesn't have to be specified.
Merge request reports
Activity
assigned to @b382190
added 1 commit
- 211512cf - Change extensions for files that require preprocessing
I think we could keep CMake 3.18. It is reasonably old (over 3 years) and provides useful feature for compile/link flags management etc, which we could use later.
But I leave to @m300488 to decide whether we should downgrade the CMake requirement in the end.
Edited by Terry Cojeanadded 9 commits
Toggle commit listadded 11 commits
-
db464b6b...8ba8e767 - 4 commits from branch
master
- 7ec2a3e8 - Change extensions for files that require preprocessing
- aba0c656 - Remove preprocessing configuration
- 9c787164 - Fix bug
- 3fec9c3b - Change extension for mo_util_texthash
- 6f7bf518 - Downgrade CMake version
- 96952b64 - Fix bug
- f713cffb - Fix bug
Toggle commit list-
db464b6b...8ba8e767 - 4 commits from branch
added 9 commits
-
f713cffb...f338ce59 - 2 commits from branch
master
- 0ae25aa3 - Change extensions for files that require preprocessing
- 5d4f7900 - Remove preprocessing configuration
- 89507e91 - Fix bug
- 8fb8e615 - Change extension for mo_util_texthash
- 8c9ef7a3 - Downgrade CMake version
- ca9d3665 - Fix bug
- 59e562e3 - Fix bug
Toggle commit list-
f713cffb...f338ce59 - 2 commits from branch
added 12 commits
-
c121ddc7...b3d5a699 - 4 commits from branch
master
- 8d06eee6 - Change extensions for files that require preprocessing
- f1d28ccc - Remove preprocessing configuration
- 4d4249ae - Fix bug
- 278b4cd0 - Change extension for mo_util_texthash
- 411d5708 - Downgrade CMake version
- e649d3e2 - Fix bug
- b6382a46 - Fix bug
- 0c3c2441 - Update README
Toggle commit list-
c121ddc7...b3d5a699 - 4 commits from branch
- Resolved by Yen-Chen Chen
- I think it's better to rename all Fortran source files to
*.F90
. You do save the preprocessing otherwise but that's negligible, I believe. - I think being careful with the minimal required version of CMake is a good idea. If it works with older versions, downgrade the requirement in the root directory. If some optional features (e.g. the tests) require a newer version, upgrade the requirement in the respective subdirectories. When you need a newer version for the core functionality, upgrade the requirement in the root with a merge request that documents why the requirement is upgraded. If you need CMake 3.19+ for the core functionality at some point, we should discuss that.
- I think it's better to rename all Fortran source files to
mentioned in merge request !3 (merged)
added 18 commits
-
0c3c2441...df9f8488 - 10 commits from branch
master
- 9af9e279 - Change extensions for files that require preprocessing
- 24392c94 - Remove preprocessing configuration
- 9c2c4e90 - Fix bug
- b3bbdff9 - Change extension for mo_util_texthash
- 7b1c4576 - Downgrade CMake version
- 484cd0a5 - Fix bug
- cf541403 - Fix bug
- 08a79a03 - Update README
Toggle commit list-
0c3c2441...df9f8488 - 10 commits from branch
added 12 commits
-
08a79a03...355298a1 - 4 commits from branch
master
- ff6eb1b5 - Change extensions for files that require preprocessing
- 2d8604ec - Remove preprocessing configuration
- 490de190 - Fix bug
- 352279bd - Change extension for mo_util_texthash
- 8b30328c - Downgrade CMake version
- d8e8dbfe - Fix bug
- e85b47d6 - Fix bug
- aa9cc569 - Update README
Toggle commit list-
08a79a03...355298a1 - 4 commits from branch
- Resolved by Yen-Chen Chen
- Resolved by Yen-Chen Chen
To keep things simple, I would merge this as it is now.
- Resolved by Yen-Chen Chen
added 34 commits
-
335cc5e5...c526a909 - 23 commits from branch
master
- 5b19fc02 - 1 earlier commit
- f551a870 - Remove preprocessing configuration
- 5d6f3fd4 - Fix bug
- 13b06180 - Change extension for mo_util_texthash
- 1bc2a980 - Downgrade CMake version
- 233aca52 - Fix bug
- 6407284b - Fix bug
- 66a39ad2 - Update README
- 078a630d - Use F90 for all modules
- b4329feb - Specify preprocessing explicitly
- 800c54e3 - Update README
Toggle commit list-
335cc5e5...c526a909 - 23 commits from branch
requested review from @m300488
mentioned in merge request !47 (closed)
mentioned in commit 38d6c949
mentioned in merge request !98 (merged)