Skip to content
Snippets Groups Projects
  1. Apr 04, 2024
  2. Apr 02, 2024
  3. Mar 16, 2024
    • Yen-Chen Chen's avatar
      Add OpenACC beautifier CI (!75) · 243a7a39
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Add OpenACC beautifier
      ## How is it implemented
      The OpenACC beautifier used in icon [here](https://gitlab.dkrz.de/icon/icon-mpim/-/blob/master/.gitlab-ci.yml?ref_type=heads#L21-L55
      
      )
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Co-authored-by: default avatarMarek Jacob <1129-b380572@users.noreply.gitlab.dkrz.de>
      Approved-by: default avatarMarek Jacob <1129-b380572@users.noreply.gitlab.dkrz.de>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: feature
      243a7a39
  4. Mar 13, 2024
    • Yen-Chen Chen's avatar
      Fix unsafe type conversion (!74) · 1f5360a3
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the bug
      The way of type conversion [here](https://gitlab.dkrz.de/icon-libraries/libfortran-support/-/blame/55913610ae02141850eb92c2ccc3f58759344646/src/mo_expression.F90?page=2#L1073
      
      ) is not suggested.
      ## How do you fix it
      Convert types specifically. 
      
      ## How urgent is the bugfix
      - [x] I need it as soon as possible
      - [ ] I can wait for a couple of days
      - [ ] None of my current codes is directly affected
      
      ## Mandatory steps before review
      - [ ] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] Bugfix is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [ ] Test coverage does not decrease
      - [ ] Reviewed by a maintainer
      - [ ] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Co-authored-by: default avatarMarek Jacob <1129-b380572@users.noreply.gitlab.dkrz.de>
      Approved-by: default avatarMarek Jacob <1129-b380572@users.noreply.gitlab.dkrz.de>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: bugfix
      1f5360a3
    • Yen-Chen Chen's avatar
      Fix test for mo_expression (!70) · 110e6e43
      Yen-Chen Chen authored
      
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the bug
      Tests in for loop are all the same.
      ## How do you fix it
      
      
      ## How urgent is the bugfix
      - [ ] I need it as soon as possible
      - [x] I can wait for a couple of days
      - [ ] None of my current codes is directly affected
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] Bugfix is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [ ] Reviewed by a maintainer
      - [ ] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: bugfix
      110e6e43
    • Yen-Chen Chen's avatar
      Change OpenACC configuration to match with math-support (!73) · 55913610
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Improve OpenACC configuration
      ## How is it implemented
      This MR follows the configuration originally set up in the `math-support` library. See [here](https://gitlab.dkrz.de/icon-libraries/libmath-support/-/blob/6ad1577a20bbae01be6050bdb8263f39653cd348/cmake/check_macro.cmake) for the reference.  
      ~~This MR waits for !69
      
       to be merged first.~~
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarPradipta Samanta <samanta@dkrz.de>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: feature
      55913610
  5. Mar 12, 2024
    • Yen-Chen Chen's avatar
      Apply naming convention for CMake options (!69) · 01e5c4c0
      Yen-Chen Chen authored
      
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      _Please describe your feature in a couple of words._
      ## How is it implemented
      _Describe important implementation details of the feature._
      
      ## Mandatory steps before review
      - [ ] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarPradipta Samanta <samanta@dkrz.de>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: feature
      01e5c4c0
  6. Mar 11, 2024
  7. Mar 04, 2024
    • Yen-Chen Chen's avatar
      Add test for fortran_tools (!68) · ea5751bf
      Yen-Chen Chen authored
      
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      _Please describe your feature in a couple of words._
      ## How is it implemented
      _Describe important implementation details of the feature._
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: other
      ea5751bf
  8. Feb 29, 2024
    • Yen-Chen Chen's avatar
      Add missing C tests (!66) · 03b240df
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Continue adding C tests. This MR closes #6
      
      
      ## How is it implemented
      
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Approved-by: default avatarTerry Cojean <terry.cojean@kit.edu>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: other
      03b240df
  9. Feb 27, 2024
    • Yen-Chen Chen's avatar
      Fix header check is always true (!67) · 14b226f5
      Yen-Chen Chen authored
      
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the bug
      The header check macros are always true
      ## How do you fix it
      Make it configured to the same as the CMake variable, where the presence of the header is checked.
      
      ## How urgent is the bugfix
      - [ ] I need it as soon as possible
      - [x] I can wait for a couple of days
      - [ ] None of my current codes is directly affected
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] Bugfix is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [ ] Reviewed by a maintainer
      - [ ] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: bugfix
      14b226f5
  10. Feb 26, 2024
    • Yen-Chen Chen's avatar
      Fix: add release tag rule to workflow (!65) · 5dfa3d60
      Yen-Chen Chen authored
      
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the bug
      Fix the problem that release is not created automatically on tag
      ## How do you fix it
      Pipeline workflow was ruled out for tags
      
      ## How urgent is the bugfix
      - [x] I need it as soon as possible
      - [ ] I can wait for a couple of days
      - [ ] None of my current codes is directly affected
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] Bugfix is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [x] Reviewed by a maintainer
      - [ ] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: feature
  11. Feb 23, 2024
    • Yen-Chen Chen's avatar
      Make release 1.1.0 (!62) · a3431d58
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      This MR makes sure that the new version with OpenACC feature can be properly merged back to `icon-mpim`
      ## How is it implemented
      See MR in icon-mpim for BuildBot results. All BuildBots must pass.
      - Doxygen-style comments are removed to following the ICON style guide
      - Intent specifiers are manually capitalized. This is an open issue for `fprettify`. See [here](https://github.com/pseewald/fprettify/issues/108
      
      )
      - [x] Put back missing subroutines
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: feature
      a3431d58
  12. Feb 01, 2024
    • Yen-Chen Chen's avatar
      Add C unit tests (!54) · 58467f01
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Add unit tests for C functions
      ## How is it implemented
      Use Googletest to implement missing unit tests in #6
      
      
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [ ] Reviewed by a maintainer
      - [ ] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: other
      58467f01
  13. Jan 31, 2024
    • Jonas Jucker's avatar
      More tests for mo_util_string (!63) · 192aa262
      Jonas Jucker authored and Yen-Chen Chen's avatar Yen-Chen Chen committed
      
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Add more unit-tests for `mo_util_string`
      ## How is it implemented
      Each public subroutine has its own test
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Co-authored-by: default avatarJonas Jucker <jonas.jucker@c2sm.ethz.ch>
      Approved-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: other
      192aa262
  14. Jan 29, 2024
    • Yen-Chen Chen's avatar
      Add OpenACC support for libfortran-support library (!3) · 38d6c949
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      _Please describe your feature in a couple of words._
      ## How is it implemented
      This branch is a temporary solution to the requirement of `mo_fortran_tools` required for the math libraries.  
      The adapted version of `mo_fortran_tools` removes the `i_am_accel_node` variable, therefore can only either not use OpenACC or use OpenACC for all nodes.
      
      - [x] This branch uses the style from !17. Merge !17
      
       first.
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Test coverage does not decrease
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Co-authored-by: default avataryanjen <yanjen224@gmail.com>
      Co-authored-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Co-authored-by: default avatarPradipta Samanta <samanta@dkrz.de>
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: feature
      38d6c949
  15. Jan 09, 2024
    • Yen-Chen Chen's avatar
      Add badges (!59) · 6653fbbc
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Add badges
      ## How is it implemented
      Adding to README. Pipelines for master branch has to be enabled for pipeline and coverage badges to show.
      - [x] This MR has to wait for !57
      
      
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: other
      6653fbbc
    • Yen-Chen Chen's avatar
      Add code coverage (!57) · c4abb003
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Add code coverage.
      ## How is it implemented
      Directly add in pipeline. The total coverage percentage will be shown in the MRs.  
      Reference: [coverage](https://docs.gitlab.com/ee/ci/testing/code_coverage.html), [coverage visualization](https://docs.gitlab.com/ee/ci/testing/test_coverage_visualization.html
      
      )
      - [x] Some CMake/FortUTF files are picked up in the coverage. Find a way to remove them.
      - [x] Backtrace test fails in sphinx runner.
      - [x] Ragel generated files cannot be processed by gcovr.  
      * Backtrace function and codes generated by Ragel are not supported in this version.
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Reviewed by a maintainer
      - [ ] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: feature
      c4abb003
  16. Jan 03, 2024
    • Yen-Chen Chen's avatar
      Remove FortUTF CMake 3.20 requirement in README (!58) · a265cfff
      Yen-Chen Chen authored
      
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the bug
      The CMake version requirement for FortUTF is downgraded to 3.17. Therefore, the line in README is no longer required.
      ## How do you fix it
      A typo is also fixed.
      
      ## How urgent is the bugfix
      - [ ] I need it as soon as possible
      - [ ] I can wait for a couple of days
      - [x] None of my current codes is directly affected
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] Bugfix is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: other
      a265cfff
    • Yen-Chen Chen's avatar
      Enable testing for NAG compiler (!55) · 33156643
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Enable testing for NAG compiler. This MR closes #10 and #12
      ## How is it implemented
      This includes fixing FortUTF to work with NAG compiler.
      - [x] PR fix for FortUTF https://github.com/artemis-beta/FortUTF/pull/21
      
      
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Co-authored-by: default avatarYen-Chen Chen <b382190@levante4.lvt.dkrz.de>
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: feature
      33156643
  17. Dec 21, 2023
    • Yen-Chen Chen's avatar
      Set up changelog for automatic release note (!56) · 6c915746
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Add changelog automation
      ## How is it implemented
      Now we have our first release, I propose that we start keeping track of the changelogs.  
      This MR sets the changelog templates that would be automatically added when a release tag is created.  
      We would have to edit the squashed commit message and choose a changelog category for the release-bot to grab the message.  
      [Here](https://about.gitlab.com/blog/2023/11/01/tutorial-automated-release-and-release-notes-with-gitlab/) and [here](https://docs.gitlab.com/ee/user/project/changelogs.html
      
      ) are references for the method.
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: other
      6c915746
  18. Dec 13, 2023
  19. Dec 12, 2023
  20. Dec 08, 2023
  21. Dec 05, 2023
  22. Nov 28, 2023
Loading