Commits on Source (8)
-
## What is the bug OpenMP optimization determines the values of `i_startblk` and `i_endblk` on its own instead of the value passed in the subroutine ## How do you fix it Removed the inclusion of `i_startblk` and `i_endblk` as private variables while starting an OMP parallel construct. It was redundant anyway. Approved-by:
Yen-Chen Chen <yen-chen.chen@kit.edu> Merged-by:
Yen-Chen Chen <yen-chen.chen@kit.edu> Changelog: bugfix
-
Generalize field declaration for the least squares reconstruction routines (!24) ## What is the new feature The field declaration of the LSQ reconstruction routines has been generalized slightly, in order to make the routines applicable to the ocean surface wave model **ICON-wave**. ## How is it implemented Currently, the 'vertical' or '3rd' dimension of the local field `z_b` is implicitly identified with `p_patch%nlev`. This is fine for the atmosphere model, but does not work for ICON-WAVE, where the 3rd dimension is the total number of spectral wave energy bins. This issue has been solved by replacing ``` REAL(wp) :: z_d(3, nproma, nlev) ``` with ``` REAL(wp) :: z_d(3, nproma, elev) ``` As a side effect, `nlev` is no longer needed by the reconstruction routines. The argument lists have been adapted accordingly. Merged-by:
Pradipta Samanta <samanta@dkrz.de> Changelog: default
-
## What is the new feature Bump license year to 2025 Merged-by:
Pradipta Samanta <samanta@dkrz.de> Changelog: other
-
## What is the new feature Support for single-precision as working-precision in libiconmath. Related to fortran-support (libfortran-support!98) Related to icon-mpim milestone (https://gitlab.dkrz.de/icon/icon-mpim/-/milestones/14#tab-issues) ## How is it implemented - Precision handling: Dependent on fortran-support `src/mo_iconlib_kind.f90` - Extensions of some functions to include sp and dp interfaces (independent of wp/sp). - Related branches before libiconmath merger: - libmath-interpolation/feature-single-precision (https://gitlab.dkrz.de/icon-libraries/libmath-interpolation/-/tree/feature-single-precision?ref_type=heads) - libmath-support/feature-single-precision (https://gitlab.dkrz.de/icon-libraries/libmath-support/-/tree/feature-single-precision?ref_type=heads ) Co-authored-by:
Pradipta Samanta <samanta@dkrz.de> Co-authored-by:
Dylan Kierans <dylankierans53@gmail.com> Merged-by:
Pradipta Samanta <samanta@dkrz.de> Changelog: feature
-
## What is the new feature Update the version of `libfortran-support` to the latest, which also supports single precision. Merged-by:
Pradipta Samanta <samanta@dkrz.de> Changelog: feature
-
## What is the bug Library links should be public. See #3. This closes #3 . ## How do you fix it Change `PRIVATE` to `PUBLIC`. Approved-by:
Pradipta Samanta <samanta@dkrz.de> Merged-by:
Pradipta Samanta <samanta@dkrz.de> Changelog: bugfix
-
## What is the bug The `config.cmake.in` was missing `find_dependency(fortran-support)` ## How do you fix it Added the missing call of `find_dependency`. Also, made the call more general and only for packages which are previously found using `find_package` during the compilation of `libiconmath` Merged-by:
Yen-Chen Chen <yen-chen.chen@tum.de> Changelog: bugfix
-
## What is the bug The use of `c_int` as a variable name in the module `mo_lib_interpolation_scalar` would create conflicts during the C++ implementation of the code. This MR solves the issue #6 ## How do you fix it The variable name `c_int` is changed to `coeff_int` Approved-by:
Yen-Chen Chen <yen-chen.chen@tum.de> Merged-by:
Yen-Chen Chen <yen-chen.chen@tum.de> Changelog: bugfix
Showing
- .gitignore 2 additions, 1 deletion.gitignore
- .reuse/templates/icon.jinja2 1 addition, 1 deletion.reuse/templates/icon.jinja2
- CMakeLists.txt 2 additions, 2 deletionsCMakeLists.txt
- REUSE.toml 4 additions, 4 deletionsREUSE.toml
- cmake/check_macro.cmake 1 addition, 1 deletioncmake/check_macro.cmake
- cmake/config.cmake.in 4 additions, 1 deletioncmake/config.cmake.in
- cmake/get_library.cmake 1 addition, 2 deletionscmake/get_library.cmake
- cmake/list_sources.cmake 1 addition, 1 deletioncmake/list_sources.cmake
- include/omp_definitions.inc 1 addition, 1 deletioninclude/omp_definitions.inc
- src/CMakeLists.txt 1 addition, 1 deletionsrc/CMakeLists.txt
- src/horizontal/CMakeLists.txt 4 additions, 4 deletionssrc/horizontal/CMakeLists.txt
- src/horizontal/mo_lib_divrot.F90 15 additions, 39 deletionssrc/horizontal/mo_lib_divrot.F90
- src/horizontal/mo_lib_gradients.F90 7 additions, 14 deletionssrc/horizontal/mo_lib_gradients.F90
- src/horizontal/mo_lib_laplace.F90 2 additions, 2 deletionssrc/horizontal/mo_lib_laplace.F90
- src/interpolation/CMakeLists.txt 3 additions, 3 deletionssrc/interpolation/CMakeLists.txt
- src/interpolation/mo_lib_interpolation_scalar.F90 401 additions, 80 deletionssrc/interpolation/mo_lib_interpolation_scalar.F90
- src/interpolation/mo_lib_interpolation_vector.F90 2 additions, 9 deletionssrc/interpolation/mo_lib_interpolation_vector.F90
- src/interpolation/mo_lib_intp_rbf.F90 146 additions, 20 deletionssrc/interpolation/mo_lib_intp_rbf.F90
- src/support/CMakeLists.txt 2 additions, 2 deletionssrc/support/CMakeLists.txt
- src/support/mo_gridman_constants.f90 2 additions, 2 deletionssrc/support/mo_gridman_constants.f90
This diff is collapsed.