Fixed a dependency issue in CMake config
All threads resolved!
All threads resolved!
What is the bug
The config.cmake.in
was missing find_dependency(fortran-support)
How do you fix it
Added the missing call of find_dependency
. Also, made the call more general and only for packages which are previously found using find_package
during the compilation of libiconmath
How urgent is the bugfix
-
I need it as soon as possible -
I can wait for a couple of days -
None of my current codes is directly affected
Mandatory steps before review
-
Gitlab CI passes (Hint: use make format
for linting) -
Bugfix is covered by additional unit tests -
Mark the merge request as ready by removing Draft:
Mandatory steps before merge
-
Reviewed by a maintainer -
Incorporate review suggestions -
Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) -
Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain
You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!
Edited by Yen-Chen Chen
Merge request reports
Activity
requested review from @b382190
assigned to @b382190
This MR tries to fix the issue #1 (closed)
Edited by Pradipta Samantamentioned in issue #1 (closed)
- Resolved by Yen-Chen Chen
To be honest, this looks more complicated than expected.
- Resolved by Yen-Chen Chen
- Resolved by Yen-Chen Chen
added bug ready for review labels
added 5 commits
-
97b0082c - 1 commit from branch
main
- 5b5a42e3 - added find_dependency for fortran-support in the cmake config file
- 5925f6dd - Enabled find_dependency only when the package is originally found via find_package
- 3934e3ab - removed the use of the additional condition before calling find_dependency
- e4afe567 - moved the use of find_package_handle_standard_args to the end of cmake config file
Toggle commit list-
97b0082c - 1 commit from branch
mentioned in commit 3208d870
Please register or sign in to reply