Skip to content
Snippets Groups Projects

Fixed a dependency issue in CMake config

Merged Pradipta Samanta requested to merge bugfix-cmake-config into main
All threads resolved!

What is the bug

The config.cmake.in was missing find_dependency(fortran-support)

How do you fix it

Added the missing call of find_dependency. Also, made the call more general and only for packages which are previously found using find_package during the compilation of libiconmath

How urgent is the bugfix

  • I need it as soon as possible
  • I can wait for a couple of days
  • None of my current codes is directly affected

Mandatory steps before review

  • Gitlab CI passes (Hint: use make format for linting)
  • Bugfix is covered by additional unit tests
  • Mark the merge request as ready by removing Draft:

Mandatory steps before merge

  • Reviewed by a maintainer
  • Incorporate review suggestions
  • Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
  • Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain

You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!

Edited by Yen-Chen Chen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sergey Kosukhin
  • added 2 commits

    • a493baad - removed the use of the additional condition before calling find_dependency
    • 8b129408 - moved the use of find_package_handle_standard_args to the end of cmake config file

    Compare with previous version

  • added 5 commits

    • 97b0082c - 1 commit from branch main
    • 5b5a42e3 - added find_dependency for fortran-support in the cmake config file
    • 5925f6dd - Enabled find_dependency only when the package is originally found via find_package
    • 3934e3ab - removed the use of the additional condition before calling find_dependency
    • e4afe567 - moved the use of find_package_handle_standard_args to the end of cmake config file

    Compare with previous version

  • Yen-Chen Chen marked the checklist item Reviewed by a maintainer as completed

    marked the checklist item Reviewed by a maintainer as completed

  • Yen-Chen Chen marked the checklist item Incorporate review suggestions as completed

    marked the checklist item Incorporate review suggestions as completed

  • Yen-Chen Chen resolved all threads

    resolved all threads

  • mentioned in commit 3208d870

  • Please register or sign in to reply
    Loading