Link Fortran libraries publically
All threads resolved!
All threads resolved!
What is the bug
Library links should be public. See #3 (closed). This closes #3 (closed).
How do you fix it
Change PRIVATE
to PUBLIC
.
How urgent is the bugfix
-
I need it as soon as possible -
I can wait for a couple of days -
None of my current codes is directly affected
Mandatory steps before review
-
Gitlab CI passes (Hint: use make format
for linting) -
Bugfix is covered by additional unit tests -
Mark the merge request as ready by removing Draft:
Mandatory steps before merge
-
Reviewed by a maintainer -
Incorporate review suggestions -
Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) -
Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain
You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!
Edited by Pradipta Samanta
Merge request reports
Activity
added bug ready for review labels
requested review from @k202170
assigned to @b382190
- Resolved by Pradipta Samanta
We need a gitlab-ci for nag compiler as well, like https://gitlab.dkrz.de/icon-libraries/libfortran-support/-/blob/master/.gitlab-ci.yml?ref_type=heads#L29-45 Should we do it here?
Edited by Pradipta Samanta
- Resolved by Pradipta Samanta
mentioned in commit 97b0082c
Please register or sign in to reply