Skip to content
Snippets Groups Projects

Link Fortran libraries publically

Merged Yen-Chen Chen requested to merge public_link into main
All threads resolved!

What is the bug

Library links should be public. See #3 (closed). This closes #3 (closed).

How do you fix it

Change PRIVATE to PUBLIC.

How urgent is the bugfix

  • I need it as soon as possible
  • I can wait for a couple of days
  • None of my current codes is directly affected

Mandatory steps before review

  • Gitlab CI passes (Hint: use make format for linting)
  • Bugfix is covered by additional unit tests
  • Mark the merge request as ready by removing Draft:

Mandatory steps before merge

  • Reviewed by a maintainer
  • Incorporate review suggestions
  • Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
  • Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain

You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!

Edited by Pradipta Samanta

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yen-Chen Chen added 1 commit

    added 1 commit

    • 09ca0ff9 - Change OpenACC link to private

    Compare with previous version

  • Yen-Chen Chen changed title from Link libraries publically to Link Fortran libraries publically

    changed title from Link libraries publically to Link Fortran libraries publically

  • Pradipta Samanta approved this merge request

    approved this merge request

  • Pradipta Samanta marked the checklist item Mark the merge request as ready by removing Draft: as completed

    marked the checklist item Mark the merge request as ready by removing Draft: as completed

  • Pradipta Samanta marked the checklist item Reviewed by a maintainer as completed

    marked the checklist item Reviewed by a maintainer as completed

  • Pradipta Samanta marked the checklist item Incorporate review suggestions as completed

    marked the checklist item Incorporate review suggestions as completed

  • Pradipta Samanta marked the checklist item Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) as completed

    marked the checklist item Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) as completed

  • Pradipta Samanta marked the checklist item Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain as completed

    marked the checklist item Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain as completed

  • Pradipta Samanta resolved all threads

    resolved all threads

  • Yen-Chen Chen mentioned in commit 97b0082c

    mentioned in commit 97b0082c

  • Please register or sign in to reply
    Loading