Skip to content
Snippets Groups Projects

Enable Changelog automation for non-latest commits

Merged Enable Changelog automation for non-latest commits
improve_changelog into master
All threads resolved!
Merged Yen-Chen Chen requested to merge improve_changelog into master
All threads resolved!

What is the new feature

Make changelog API to search for changelogs until the target commit. This way we can mange the versions more easily.

How is it implemented

In the GitLab Changelog API, the default from attribute is the last tag, which is exactly what we wanted. The default to attribute is the latest commit at the default branch. We change it to the target commit where we create the tag.

Edited by Mikael Stellio

Merge request reports

Merge request pipeline #101523 passed

Stage: lint
Stage: build_and_test
Stage: build_and_test_OpenMP
Stage: build_OpenACC
Stage: coverage

Merge request pipeline passed for 7753e049

Test coverage 81.30% (0.00%) from 1 job
Approved by
Mikael Stellio

Merged by Mikael StellioMikael Stellio 1 month ago (Mar 28, 2025 1:18pm UTC)

Merge details

  • Changes merged into master with 169143ef (commits were squashed).
  • Deleted the source branch.

Pipeline #101653 passed

Stage: lint
Stage: build_and_test
Stage: build_and_test_OpenMP
Stage: build_OpenACC
Stage: coverage

Pipeline passed for 169143ef on master

Test coverage 81.30% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yen-Chen Chen requested review from @b382090

    requested review from @b382090

  • Yen-Chen Chen assigned to @b382190

    assigned to @b382190

  • Yen-Chen Chen
    Yen-Chen Chen @b382190 ·
    Author Owner

    Hi @b382090, please let me know if you have any questions regarding the review process or anything else.

  • Yen-Chen Chen marked the checklist item Mark the merge request as ready by removing Draft: as completed

    marked the checklist item Mark the merge request as ready by removing Draft: as completed

  • Yen-Chen Chen marked the checklist item Gitlab CI passes (Hint: use make format for linting) as completed

    marked the checklist item Gitlab CI passes (Hint: use make format for linting) as completed

    • Mikael Stellio
      Mikael Stellio @b382090 ·
      Maintainer
      Resolved by Mikael Stellio

      Hi Yen-Chen,

      If you don't mind, could you give me an overview of your general workflow for reviews? Such that I don't go completely off-track.

      Also, dumb question: are the steps described in the template ("Mandatory steps before review" and "Mandatory steps before merge") something that the reviewer should do or is the assignee responsible?

      Who merges? Reviewer or assignee?

      Edited by Mikael Stellio
  • Mikael Stellio
    Mikael Stellio @b382090 ·
    Maintainer

    Otherwise, regarding this MR: your change looks good to me :thumbsup:

  • Mikael Stellio approved this merge request

    approved this merge request

  • Mikael Stellio marked the checklist item Test coverage does not decrease as completed

    marked the checklist item Test coverage does not decrease as completed

  • Mikael Stellio marked the checklist item Reviewed by a maintainer as completed

    marked the checklist item Reviewed by a maintainer as completed

  • Mikael Stellio marked the checklist item Incorporate review suggestions as completed

    marked the checklist item Incorporate review suggestions as completed

  • Mikael Stellio marked the checklist item Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain as completed

    marked the checklist item Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain as completed

  • Mikael Stellio marked the checklist item Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) as completed

    marked the checklist item Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) as completed

  • Mikael Stellio marked the checklist item Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) as incomplete

    marked the checklist item Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) as incomplete

  • Mikael Stellio changed the description

    changed the description

  • Mikael Stellio resolved all threads

    resolved all threads

  • Mikael Stellio merged

    merged

  • Yen-Chen Chen mentioned in commit 169143ef

    mentioned in commit 169143ef

Please register or sign in to reply

Imprint | Privacy Policy