Skip to content

Improve OpenMP configuration

Yen-Chen Chen requested to merge fix_omp_config into master

What is the bug

OpenMP_C is not used and cannot be found with Mac clang, which cause a compile trouble. This MR solves #25 (closed).

How do you fix it

Only find OpenMP and link for Fortran. Along the way, one bug for insert_dimension is also fixed with this MR.

How urgent is the bugfix

  • I need it as soon as possible
  • I can wait for a couple of days
  • None of my current codes is directly affected

Mandatory steps before review

  • Gitlab CI passes (Hint: use make format for linting)
  • Bugfix is covered by additional unit tests
  • Mark the merge request as ready by removing Draft:

Mandatory steps before merge

  • Test coverage does not decrease
  • Reviewed by a maintainer
  • Incorporate review suggestions
  • Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain
  • Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)

You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!

Edited by Pradipta Samanta

Merge request reports

Loading