Improve OpenMP configuration
What is the bug
OpenMP_C
is not used and cannot be found with Mac clang, which cause a compile trouble. This MR solves #25 (closed).
How do you fix it
Only find OpenMP and link for Fortran.
Along the way, one bug for insert_dimension
is also fixed with this MR.
How urgent is the bugfix
-
I need it as soon as possible -
I can wait for a couple of days -
None of my current codes is directly affected
Mandatory steps before review
-
Gitlab CI passes (Hint: use make format
for linting) -
Bugfix is covered by additional unit tests -
Mark the merge request as ready by removing Draft:
Mandatory steps before merge
-
Test coverage does not decrease -
Reviewed by a maintainer -
Incorporate review suggestions -
Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain -
Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!
Edited by Pradipta Samanta
Merge request reports
Activity
assigned to @b382190
added bug ready for review labels
requested review from @b381001
added 2 commits
added 10 commits
-
555fd59f - 1 commit from branch
master
- 2aa7caba - Improve OpenMP configuration
- 63903edf - Add GNU OpenMP test
- db4b7f46 - Add OpenMP CI for all compilers
- 4658b288 - Fix bug for insert_dimension (only shown when OMP is enabled)
- 20255353 - Remove OpenMP NAG CI
- eb829538 - Improve OpenMP configuration
- ba63ba88 - Delete impossible if clause
- 765b1020 - Fix code duplication by rebase
- bbd5b08a - Recover irrelevant update
Toggle commit list-
555fd59f - 1 commit from branch
Please register or sign in to reply