Skip to content
Snippets Groups Projects

CMake Improvements, Tests and Installation

    • Open Issue created by Oliver Heidmann @m300433

    The current CMake build system does not provide a way to install CDI via cmake. Meanwhile the whole CMake system is generally in a experimental state and needs to be reworked and finished.

    Designs

      Child items ...

      2. Activity

      • Oliver Heidmann assigned to @m300433

        assigned to @m300433

      • Oliver Heidmann made the issue visible to everyone

        made the issue visible to everyone

        • M
          Oliver Heidmann @m300433 ·
          Author Maintainer

          @m214003 @b383306 Due to the experimental nature of the current CMake system I think we should not work each on their own as there will be a lot of changes of the next time. I will further improve CMake (with help) over the next few weeks. What I need is a proper set of requirements and some background info. @b383306

          • What do you need the installation via CMake for?
          • When do you need it and does it block your current progress?
          • Can you provide us with Tests that we can add so that we don't break CDI for you later on.
          • Is there a branch of Paraview that we can access where you are working and where CDI is used in a way that we can glimpse what you require and where we can test if our implementation works?

          I ask this because I cannot guarantee the speed at which I get everything up and running. I have someone at the MPI-M who wants to/I asked to recheck my now merged changes but that will take some time as I probably made quite a lot of beginners mistakes. I really want to avoid external additions where we have planned to do them anyway.

          So for everyone to be happy Id like to see either a proper set of requirements that we can discuss/ implement for you
          OR
          a ready merge request that fulfills everything where I can copy or merge the required changes.
          With the currently very small merge requests I am unable to see the intention behind it or why it is required.

        • Mathieu Westphal
          Mathieu Westphal @b383306 ·
          Contributor

          Hi @m300433

          What is you goal, what are you trying to achieve

          I want to be able to build and install libcdi on Windows, MacOS and Linux using CMake, in order to be able to enabled the CDIReader plugin on all our supported platforms.

          What do you need the installation via CMake for?

          I need a fonctional libcdi for the vtkCDIReader of the CDIReader plugin of ParaView. I have already wrote the installation code I need if you want it.

          When do you need it and does it block your current progress?

          Nothing is blocked on my side as I can just patch libcdi current release in our process, but the less patches the better.

          Can you provide us with Tests that we can add so that we don't break CDI for you later on.

          CMake tests ? What is needed if a CI workflow that rely on CMake, not Makefile. I'm afraid I wont be able to work on that, as I cannot run pipelines on this gitlab.

          Is there a branch of Paraview that we can access where you are working and where CDI is used in a way that we can glimpse what you require and where we can test if our implementation works?

          ParaView master contains the CDIReader plugin. Just enable it, it will then look for libcdi. This is been the case for many years.

          Id like to see either a proper set of requirement

          I hope that covers it. Keep in mind that I'm happy to develop anything that help me reach my goals. I can also help review your own CMake work if you want.

          a ready merge request that fulfills everything where I can copy or merge the required changes.

          I disagree, changes should be as atomic as possible, with an explanation of what they do and why they are implemented. Maybe I should improve on that.

          In any case, I'm happy to follow your process.

          Let me know if you need more information and what I can do to help.

          Best,

        • M
          Oliver Heidmann @m300433 ·
          Author Maintainer

          I need a fonctional libcdi for the vtkCDIReader of the CDIReader plugin of ParaView. I have already wrote the installation code I need if you want it.

          Id like to see those changes. I guess you mean the CMake installation code?

          I disagree, changes should be as atomic as possible, with an explanation of what they do and why they are implemented. Maybe I should improve on that.

          With the current workflow this would be really really slow. And would make both of our lives harder. I just want to see the whole result in one go to better understand it and to be able to discuss the changes with the person who helps me with the whole CMake implementation. When you tell us that the changes are ready to be merged on your side we would probably change some things and then merge into develop so that the changes are available with the next release (at least that is the best case scenario). That would also allow you to see what we do and if we break something. The easiest for us would be if you create a branch which we can look through.

          I am of course open for discussing this approach.

        • Mathieu Westphal
          Mathieu Westphal @b383306 ·
          Contributor

          Hi @m300433

          I guess you mean the CMake installation code?

          Indeed,

          Sure I can prepare a branch containing all the CMake changes I have in mind.

          Best,

          Edited by Mathieu Westphal
        • Mathieu Westphal
          Mathieu Westphal @b383306 ·
          Contributor

          Here is my branch: !134 (merged)

        • Please register or sign in to reply
      Please register or sign in to reply

      Imprint | Privacy Policy