Draft: Do dot product with Kokkos subview

What is the new feature

Replace ugly expanded dot product with std::inner_product using Kokkos subviews.

How is it implemented

Get vector by Kokkos subview, which can be passed in std::inner_product.

The advantage is

1. No lambda functions, no extra wrapper class.
2. Readable code

The disadvantage is

1. Use functions of Kokkos::Experimental (iterators), which might need to be updated with future Kokkos versions.
2. No guarantee of performance.

Mandatory steps before review

• Gitlab CI passes (Hint: use make format for linting)
• New feature is covered by additional unit tests
• Mark the merge request as ready by removing Draft:

Mandatory steps before merge

• Reviewed by a maintainer
• Incorporate review suggestions
• Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
• Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain

You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!

test/c/test_horizontal_divrot.cpp

@@ -1323,21 +1323,9 @@ protected:
   }
 };
 
-template <typename ValueType>
-class HorizontalDiv3DTest : public HorizontalDivTest<ValueType> {};
-
-template <typename ValueType>
-class HorizontalDiv3D2FTest : public HorizontalDivTest<ValueType> {};
-
-template <typename ValueType>
-class HorizontalDiv4DTest : public HorizontalDivTest<ValueType> {};
+TYPED_TEST_SUITE(HorizontalDivTest, ValueTypes);
 
-template <typename ValueType>
-class HorizontalDivAvgTest : public HorizontalDivTest<ValueType> {};
-
-TYPED_TEST_SUITE(HorizontalDiv3DTest, ValueTypes);
-
-TYPED_TEST(HorizontalDiv3DTest, TestSpecific) {
+TYPED_TEST(HorizontalDivTest, TestDiv3DSpecific) {
   constexpr int nproma = this->nproma;
   constexpr int nlev = this->nlev;
   constexpr int nblks_c = this->nblks_c;
@@ -1391,7 +1379,7 @@ TYPED_TEST(HorizontalDiv3DTest, TestSpecific) {
   EXPECT_NEAR(this->div_vec_c[div_vec_c_at(2, 1, 0)], 4.4, 1e-6);
 }
 
-TYPED_TEST(HorizontalDiv3DTest, TestRandom) {
+TYPED_TEST(HorizontalDivTest, TestDiv3DRandom) {
   constexpr int nproma = this->nproma;
   constexpr int nlev = this->nlev;
   constexpr int nblks_c = this->nblks_c;
@@ -1477,9 +1465,7 @@ TYPED_TEST(HorizontalDiv3DTest, TestRandom) {
   }
 }
 
-TYPED_TEST_SUITE(HorizontalDiv3D2FTest, ValueTypes);
-
-TYPED_TEST(HorizontalDiv3D2FTest, TestSpecific) {
+TYPED_TEST(HorizontalDivTest, TestDiv3D2FSpecific) {
   constexpr int nproma = this->nproma;
   constexpr int nlev = this->nlev;
   constexpr int nblks_c = this->nblks_c;
@@ -1549,7 +1535,7 @@ TYPED_TEST(HorizontalDiv3D2FTest, TestSpecific) {
   EXPECT_NEAR(this->f4dout[f4dout_at(2, 1, 0, 0)], 6.6, 1e-6);
 }
 
-TYPED_TEST(HorizontalDiv3D2FTest, TestRandom) {
+TYPED_TEST(HorizontalDivTest, TestDiv3D2FRandom) {
   constexpr int nproma = this->nproma;
   constexpr int nlev = this->nlev;
   constexpr int nblks_c = this->nblks_c;
@@ -1667,9 +1653,7 @@ TYPED_TEST(HorizontalDiv3D2FTest, TestRandom) {
   }
 }
 
-TYPED_TEST_SUITE(HorizontalDiv4DTest, ValueTypes);
-
-TYPED_TEST(HorizontalDiv4DTest, TestSpecific) {
+TYPED_TEST(HorizontalDivTest, TestDiv4DSpecific) {
   constexpr int nproma = this->nproma;
   constexpr int nlev = this->nlev;
   constexpr int nblks_c = this->nblks_c;
@@ -1719,7 +1703,7 @@ TYPED_TEST(HorizontalDiv4DTest, TestSpecific) {
   EXPECT_NEAR(this->f4dout[f4dout_at(2, 1, 0, 1)], 2.3, 1e-6);
 }
 
-TYPED_TEST(HorizontalDiv4DTest, TestDiv4dRandom) {
+TYPED_TEST(HorizontalDivTest, TestDiv4DRandom) {
   constexpr int nproma = this->nproma;
   constexpr int nlev = this->nlev;
   constexpr int nblks_c = this->nblks_c;
@@ -1787,9 +1771,9 @@ TYPED_TEST(HorizontalDiv4DTest, TestDiv4dRandom) {
   }
 }
 
-TYPED_TEST_SUITE(HorizontalDivAvgTest, ValueTypes);
+TYPED_TEST_SUITE(HorizontalDivTest, ValueTypes);
 
-TYPED_TEST(HorizontalDivAvgTest, TestSpecific) {
+TYPED_TEST(HorizontalDivTest, TestDivAvgSpecific) {
   constexpr int nproma = this->nproma;
   constexpr int nlev = this->nlev;
   constexpr int nblks_c = this->nblks_c;
@@ -1884,7 +1868,7 @@ TYPED_TEST(HorizontalDivAvgTest, TestSpecific) {
   EXPECT_NEAR(this->opt_out2[div_vec_c_at(2, 1, 0)], 2.08, 1e-6);
 }
 
-TYPED_TEST(HorizontalDivAvgTest, TestRandom) {
+TYPED_TEST(HorizontalDivTest, TestDivAvgRandom) {
   constexpr int nproma = this->nproma;
   constexpr int nlev = this->nlev;
   constexpr int nblks_c = this->nblks_c;
@@ -2079,7 +2063,7 @@ TYPED_TEST(HorizontalDivAvgTest, TestRandom) {
   }
 }
 
-TYPED_TEST(HorizontalDivAvgTest, TestSpecificNoL2fields) {
+TYPED_TEST(HorizontalDivTest, TestDivAvgSpecificNoL2fields) {
   constexpr int nproma = this->nproma;
   constexpr int nlev = this->nlev;
   constexpr int nblks_c = this->nblks_c;
@@ -2173,7 +2157,7 @@ TYPED_TEST(HorizontalDivAvgTest, TestSpecificNoL2fields) {
   EXPECT_NEAR(this->opt_out2[div_vec_c_at(2, 1, 0)], 0.0, 1e-6);
 }
 
-TYPED_TEST(HorizontalDivAvgTest, TestRandomNoL2fields) {
+TYPED_TEST(HorizontalDivTest, TestDivAvgRandomNoL2fields) {
   constexpr int nproma = this->nproma;
   constexpr int nlev = this->nlev;
   constexpr int nblks_c = this->nblks_c;