Draft: Do dot product with Kokkos subview
What is the new feature
Replace ugly expanded dot product with std::inner_product
using Kokkos subviews.
How is it implemented
Get vector by Kokkos subview, which can be passed in std::inner_product
.
The advantage is
- No lambda functions, no extra wrapper class.
- Readable code
The disadvantage is
- Use functions of Kokkos::Experimental (iterators), which might need to be updated with future Kokkos versions.
- No guarantee of performance.
Mandatory steps before review
-
Gitlab CI passes (Hint: use make format
for linting) -
New feature is covered by additional unit tests -
Mark the merge request as ready by removing Draft:
Mandatory steps before merge
-
Reviewed by a maintainer -
Incorporate review suggestions -
Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) -
Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain
You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!
Merge request reports
Activity
added C++ improvement label
assigned to @b382190
added 13 commits
-
100635bf...bad07242 - 11 commits from branch
lib-divrot-add-cpp-codes
- 18bf4626 - Inner product with Kokkos subview
- 96a21fb0 - Fix bug
-
100635bf...bad07242 - 11 commits from branch
added 6 commits
-
96a21fb0...45037019 - 4 commits from branch
lib-divrot-add-cpp-codes
- a731e8ab - Inner product with Kokkos subview
- e9824f23 - Fix bug
-
96a21fb0...45037019 - 4 commits from branch
added 35 commits
-
0c5f7d1d - 1 commit from branch
feature-add-cpp-codes
- 0c5f7d1d...db48810e - 24 earlier commits
- f058425d - added rest of the unit tests for div3d, div4d and divavg
- 4f98e9ec - added unit tests for rest of the functions
- 5303c536 - applied clang-format to the test file
- 462354b6 - reverted back some changes
- 35559235 - Remove redundant code
- 15a3f377 - Rename lib_divrot to mo_lib_divrot
- 2cdd3542 - Combine Div tests
- 4810925a - Split tests into three files
- e0962b8e - Inner product with Kokkos subview
- 11608d6d - Fix bug
Toggle commit list-
0c5f7d1d - 1 commit from branch
added 76 commits
-
11608d6d...af882064 - 42 commits from branch
feature-add-cpp-codes
- af882064...fa21f9cd - 24 earlier commits
- be53ae73 - added rest of the unit tests for div3d, div4d and divavg
- eb173643 - added unit tests for rest of the functions
- 7d9be327 - applied clang-format to the test file
- 095b1d6b - reverted back some changes
- 5126e3d3 - Remove redundant code
- a7329d46 - Rename lib_divrot to mo_lib_divrot
- f5e69c5a - Combine Div tests
- de9c210e - Split tests into three files
- 1991101a - Inner product with Kokkos subview
- 33424eb6 - Fix bug
Toggle commit list-
11608d6d...af882064 - 42 commits from branch
Please register or sign in to reply