Skip to content
Snippets Groups Projects

Restore present check for set_acc_host_or_device

Merged Yen-Chen Chen requested to merge revert_set_acc_host_or_device into master

What is the bug

The present check in the set_acc_host_or_device is heavily used in ICON and cannot be changed easily.
This problem comes from the discussion at https://gitlab.dkrz.de/icon/icon-mpim/-/merge_requests/563#note_276277

How do you fix it

Revert the changes.

How urgent is the bugfix

  • I need it as soon as possible
  • I can wait for a couple of days
  • None of my current codes is directly affected

Mandatory steps before review

  • Gitlab CI passes (Hint: use make format for linting)
  • Bugfix is covered by additional unit tests
  • Mark the merge request as ready by removing Draft:

Mandatory steps before merge

  • Test coverage does not decrease
  • Reviewed by a maintainer
  • Incorporate review suggestions
  • Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain
  • Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)

You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!

Edited by Yen-Chen Chen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yen-Chen Chen requested review from @b380572

    requested review from @b380572

  • assigned to @b382190

  • Yen-Chen Chen changed the description

    changed the description

  • Marek Jacob approved this merge request

    approved this merge request

  • Yen-Chen Chen marked the checklist item Test coverage does not decrease as completed

    marked the checklist item Test coverage does not decrease as completed

  • Yen-Chen Chen marked the checklist item Reviewed by a maintainer as completed

    marked the checklist item Reviewed by a maintainer as completed

  • Yen-Chen Chen marked the checklist item Gitlab CI passes (Hint: use make format for linting) as completed

    marked the checklist item Gitlab CI passes (Hint: use make format for linting) as completed

  • Yen-Chen Chen marked the checklist item Mark the merge request as ready by removing Draft: as completed

    marked the checklist item Mark the merge request as ready by removing Draft: as completed

  • Yen-Chen Chen marked the checklist item Incorporate review suggestions as completed

    marked the checklist item Incorporate review suggestions as completed

  • Yen-Chen Chen marked the checklist item Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain as completed

    marked the checklist item Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain as completed

  • Yen-Chen Chen marked the checklist item Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) as completed

    marked the checklist item Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) as completed

  • Yen-Chen Chen mentioned in commit ce4db273

    mentioned in commit ce4db273

  • Yen-Chen Chen mentioned in commit f7de0957

    mentioned in commit f7de0957

Please register or sign in to reply
Loading