Skip to content
Snippets Groups Projects
  1. Jan 10, 2024
  2. Jan 09, 2024
    • Yen-Chen Chen's avatar
      Add badges (!59) · 6653fbbc
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Add badges
      ## How is it implemented
      Adding to README. Pipelines for master branch has to be enabled for pipeline and coverage badges to show.
      - [x] This MR has to wait for !57
      
      
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: other
      6653fbbc
    • Yen-Chen Chen's avatar
      Add code coverage (!57) · c4abb003
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Add code coverage.
      ## How is it implemented
      Directly add in pipeline. The total coverage percentage will be shown in the MRs.  
      Reference: [coverage](https://docs.gitlab.com/ee/ci/testing/code_coverage.html), [coverage visualization](https://docs.gitlab.com/ee/ci/testing/test_coverage_visualization.html
      
      )
      - [x] Some CMake/FortUTF files are picked up in the coverage. Find a way to remove them.
      - [x] Backtrace test fails in sphinx runner.
      - [x] Ragel generated files cannot be processed by gcovr.  
      * Backtrace function and codes generated by Ragel are not supported in this version.
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Reviewed by a maintainer
      - [ ] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: feature
      c4abb003
  3. Jan 03, 2024
    • Yen-Chen Chen's avatar
      Remove FortUTF CMake 3.20 requirement in README (!58) · a265cfff
      Yen-Chen Chen authored
      
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the bug
      The CMake version requirement for FortUTF is downgraded to 3.17. Therefore, the line in README is no longer required.
      ## How do you fix it
      A typo is also fixed.
      
      ## How urgent is the bugfix
      - [ ] I need it as soon as possible
      - [ ] I can wait for a couple of days
      - [x] None of my current codes is directly affected
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] Bugfix is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Changelog: other
      a265cfff
    • Yen-Chen Chen's avatar
      Enable testing for NAG compiler (!55) · 33156643
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Enable testing for NAG compiler. This MR closes #10 and #12
      ## How is it implemented
      This includes fixing FortUTF to work with NAG compiler.
      - [x] PR fix for FortUTF https://github.com/artemis-beta/FortUTF/pull/21
      
      
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Co-authored-by: default avatarYen-Chen Chen <b382190@levante4.lvt.dkrz.de>
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: feature
      33156643
  4. Dec 21, 2023
    • Yen-Chen Chen's avatar
      Set up changelog for automatic release note (!56) · 6c915746
      Yen-Chen Chen authored
      <!--
      ICON
      
      ---------------------------------------------------------------
      Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
      Contact information: icon-model.org
      
      See AUTHORS.TXT for a list of authors
      See LICENSES/ for license information
      SPDX-License-Identifier: CC0-1.0
      ---------------------------------------------------------------
      -->
      
      ## What is the new feature
      Add changelog automation
      ## How is it implemented
      Now we have our first release, I propose that we start keeping track of the changelogs.  
      This MR sets the changelog templates that would be automatically added when a release tag is created.  
      We would have to edit the squashed commit message and choose a changelog category for the release-bot to grab the message.  
      [Here](https://about.gitlab.com/blog/2023/11/01/tutorial-automated-release-and-release-notes-with-gitlab/) and [here](https://docs.gitlab.com/ee/user/project/changelogs.html
      
      ) are references for the method.
      
      ## Mandatory steps before review
      - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
      - [x] New feature is covered by additional unit tests
      - [x] Mark the merge request as ready by removing `Draft:`
      
      ## Mandatory steps before merge
      - [x] Reviewed by a maintainer
      - [x] Incorporate review suggestions
      - [x] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
      
      **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
      
      Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
      Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
      Changelog: other
      6c915746
  5. Dec 13, 2023
  6. Dec 12, 2023
  7. Dec 08, 2023
  8. Dec 05, 2023
  9. Nov 28, 2023
  10. Nov 27, 2023
  11. Nov 22, 2023
Loading