Skip to content
Snippets Groups Projects
  • Yen-Chen Chen's avatar
    a3431d58
    Make release 1.1.0 (!62) · a3431d58
    Yen-Chen Chen authored
    <!--
    ICON
    
    ---------------------------------------------------------------
    Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
    Contact information: icon-model.org
    
    See AUTHORS.TXT for a list of authors
    See LICENSES/ for license information
    SPDX-License-Identifier: CC0-1.0
    ---------------------------------------------------------------
    -->
    
    ## What is the new feature
    This MR makes sure that the new version with OpenACC feature can be properly merged back to `icon-mpim`
    ## How is it implemented
    See MR in icon-mpim for BuildBot results. All BuildBots must pass.
    - Doxygen-style comments are removed to following the ICON style guide
    - Intent specifiers are manually capitalized. This is an open issue for `fprettify`. See [here](https://github.com/pseewald/fprettify/issues/108
    
    )
    - [x] Put back missing subroutines
    
    ## Mandatory steps before review
    - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
    - [x] New feature is covered by additional unit tests
    - [x] Mark the merge request as ready by removing `Draft:`
    
    ## Mandatory steps before merge
    - [x] Test coverage does not decrease
    - [x] Reviewed by a maintainer
    - [x] Incorporate review suggestions
    - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
    
    **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
    
    Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
    Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
    Changelog: feature
    a3431d58
    History
    Make release 1.1.0 (!62)
    Yen-Chen Chen authored
    <!--
    ICON
    
    ---------------------------------------------------------------
    Copyright (C) 2004-2024, DWD, MPI-M, DKRZ, KIT, ETH, MeteoSwiss
    Contact information: icon-model.org
    
    See AUTHORS.TXT for a list of authors
    See LICENSES/ for license information
    SPDX-License-Identifier: CC0-1.0
    ---------------------------------------------------------------
    -->
    
    ## What is the new feature
    This MR makes sure that the new version with OpenACC feature can be properly merged back to `icon-mpim`
    ## How is it implemented
    See MR in icon-mpim for BuildBot results. All BuildBots must pass.
    - Doxygen-style comments are removed to following the ICON style guide
    - Intent specifiers are manually capitalized. This is an open issue for `fprettify`. See [here](https://github.com/pseewald/fprettify/issues/108
    
    )
    - [x] Put back missing subroutines
    
    ## Mandatory steps before review
    - [x] Gitlab CI passes _(Hint: use `make format` for linting)_ 
    - [x] New feature is covered by additional unit tests
    - [x] Mark the merge request as ready by removing `Draft:`
    
    ## Mandatory steps before merge
    - [x] Test coverage does not decrease
    - [x] Reviewed by a maintainer
    - [x] Incorporate review suggestions
    - [ ] Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
    
    **You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!**
    
    Approved-by: default avatarJonas Jucker <jonas.jucker@env.ethz.ch>
    Merged-by: default avatarYen-Chen Chen <yen-chen.chen@kit.edu>
    Changelog: feature