Skip to content
Snippets Groups Projects

Update playbooks typos

Merged Etor Lucio Eceiza requested to merge update_playbooks-typos into update_playbooks
All threads resolved!

minimal changes,

  • I wanted to change the position of the checkboxes (to the end of the sentence) but I was unable to
  • I also wanted to change base.py main checkbox to give some space from the rest to make a clear distinction, e.g.:
[ ] Use this step


1. Server Name(s) where core is deployed:
...

but I was unsucessfull.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Since the pipeline didn't work I ran the jobs manually and it happens to be that black crashes:

    black --check src                                                                                                            
    would reformat /home/wilfred/workspace/deployment/src/freva_deployment/cli/_deploy.py
    would reformat /home/wilfred/workspace/deployment/src/freva_deployment/cli/_server_map.py
    would reformat /home/wilfred/workspace/deployment/src/freva_deployment/cli/_service.py
    would reformat /home/wilfred/workspace/deployment/src/freva_deployment/ui/deployment_tui/base.py
    would reformat /home/wilfred/workspace/deployment/src/freva_deployment/ui/deployment_tui/main_window.py
    would reformat /home/wilfred/workspace/deployment/src/freva_deployment/utils.py
    would reformat /home/wilfred/workspace/deployment/src/freva_deployment/deploy.py
    would reformat /home/wilfred/workspace/deployment/src/freva_deployment/ui/deployment_tui/deploy_forms.py
    Oh no! 💥 💔 💥
    
    8 files would be reformatted, 5 files would be left unchanged.

    Can you simply reformat the files? black src/ ?

  • I am running black and I see the following locally:

    $ black --check src/
    All done! ✨ 🍰 ✨
    13 files would be left unchanged.

    I did not even edit most of these files

    I am checking my black version and:

    (freva-dev) [etor@ECEIZALAP /home/etor/work/freva/deployment] (update_playbooks-typos)
    $ black --version
    black, 22.3.0 (compiled: yes)
    (freva-dev) [etor@ECEIZALAP /home/etor/work/freva/deployment] (update_playbooks-typos)
    $ which black
    /home/etor/.conda/envs/freva-dev/bin/black
    (freva-dev) [etor@ECEIZALAP /home/etor/work/freva/deployment] (update_playbooks-typos)
    $ ls -lrt /home/etor/.conda/envs/freva-dev/bin/black
    -rwxr-xr-x 1 etor etor 247 Jun 13 15:59 /home/etor/.conda/envs/freva-dev/bin/black

    this is from the feva-dev environment I just installed yesterday for evaluation_system repo

  • added 1 commit

    • ce9127a6 - Use eval docker container to build docs

    Compare with previous version

  • Martin Bergemann added 3 commits

    added 3 commits

    • bcc81a66 - use eval system docker for ci pipeline
    • 0a2909e0 - Merge branch 'update_playbooks-typos' of...
    • 9a5ff2e2 - Clean up pipline definition

    Compare with previous version

  • added 1 commit

    • c1272445 - Install make before creating docs

    Compare with previous version

  • Martin Bergemann resolved all threads

    resolved all threads

  • added 1 commit

    • e5a49489 - Add no needs flag to pipeline jobs

    Compare with previous version

  • added 1 commit

    • 894fce63 - Run CI pipeline on python docker container

    Compare with previous version

  • Martin Bergemann approved this merge request

    approved this merge request

  • Ok the pipeline has passed....LGTM!

  • Ok I'll just go ahead and merge this.

  • mentioned in commit 6f448e48

  • Please register or sign in to reply
    Loading