Update playbooks typos
All threads resolved!
All threads resolved!
minimal changes,
- I wanted to change the position of the checkboxes (to the end of the sentence) but I was unable to
- I also wanted to change
base.py
main checkbox to give some space from the rest to make a clear distinction, e.g.:
[ ] Use this step
1. Server Name(s) where core is deployed:
...
but I was unsucessfull.
Merge request reports
Activity
requested review from @m300765
- Resolved by Martin Bergemann
Since the pipeline didn't work I ran the jobs manually and it happens to be that black crashes:
black --check src would reformat /home/wilfred/workspace/deployment/src/freva_deployment/cli/_deploy.py would reformat /home/wilfred/workspace/deployment/src/freva_deployment/cli/_server_map.py would reformat /home/wilfred/workspace/deployment/src/freva_deployment/cli/_service.py would reformat /home/wilfred/workspace/deployment/src/freva_deployment/ui/deployment_tui/base.py would reformat /home/wilfred/workspace/deployment/src/freva_deployment/ui/deployment_tui/main_window.py would reformat /home/wilfred/workspace/deployment/src/freva_deployment/utils.py would reformat /home/wilfred/workspace/deployment/src/freva_deployment/deploy.py would reformat /home/wilfred/workspace/deployment/src/freva_deployment/ui/deployment_tui/deploy_forms.py Oh no! 💥 💔 💥 8 files would be reformatted, 5 files would be left unchanged.
Can you simply reformat the files?
black src/
?I am running black and I see the following locally:
$ black --check src/ All done! ✨ 🍰 ✨ 13 files would be left unchanged.
I did not even edit most of these files
I am checking my black version and:
(freva-dev) [etor@ECEIZALAP /home/etor/work/freva/deployment] (update_playbooks-typos) $ black --version black, 22.3.0 (compiled: yes) (freva-dev) [etor@ECEIZALAP /home/etor/work/freva/deployment] (update_playbooks-typos) $ which black /home/etor/.conda/envs/freva-dev/bin/black (freva-dev) [etor@ECEIZALAP /home/etor/work/freva/deployment] (update_playbooks-typos) $ ls -lrt /home/etor/.conda/envs/freva-dev/bin/black -rwxr-xr-x 1 etor etor 247 Jun 13 15:59 /home/etor/.conda/envs/freva-dev/bin/black
this is from the
feva-dev
environment I just installed yesterday forevaluation_system
repo- Resolved by Martin Bergemann
True, my bad, I forgot to switch to the freva-dev env and did it from my base env which has a different python version .
mentioned in commit 6f448e48
Please register or sign in to reply