Miscellaneous fixes and CDI-PIO improvements (!89) · Merge requests · mpim-sw / libcdi

Merged Thomas Jahns requested to merge k202069/develop into develop 10 months ago

Jul 02, 2024
- Apply clang-format. · 80625115
  Thomas Jahns authored 10 months ago
  
  80625115
- Annotate unused argument. · d6f4dce4
  Thomas Jahns authored 10 months ago
  
  d6f4dce4
- Test stricter CI setup. · 092f0167
  Thomas Jahns authored 10 months ago
  
  092f0167
- Fix implicit conversions. · ac6a9324
  Thomas Jahns authored 10 months ago
  
  * Also sizeof (char) == 1 by C language definition.
  ac6a9324
- Limit range of values in print. · 23e458f1
  Thomas Jahns authored 10 months ago
  
  * Otherwise snprintf might truncate the output.
  23e458f1
- Fix implicit conversion. · 787add30
  Thomas Jahns authored 10 months ago
  
  787add30
- Tell gcc about the value range. · 827927e1
  Thomas Jahns authored 10 months ago
  
  * Otherwise, gcc assumes large numerical values of the time stamp components might lead to truncation of unitstr_.
  827927e1
- Move variable definition into block using it. · b66bd535
  Thomas Jahns authored 10 months ago
  
  b66bd535
- Fix missing deallocation of one-time allocation. · 65286312
  Thomas Jahns authored 10 months ago
  
  65286312
- Fix run-time warning generated by GRB1 tests. · 153a15d4
  Thomas Jahns authored 10 months ago
  
  153a15d4
- Reorder tests to simplify branching. · 328dbc52
  Thomas Jahns authored 10 months ago
  
  * This way the compiler can first use isText and isNumber to decide on the path.
  328dbc52
- Conditionally declare unused parameter. · 7f89b542
  Thomas Jahns authored 10 months ago
  
  7f89b542
- Prevent use of outdated pointers. · 1472ca52
  Thomas Jahns authored 10 months ago
  
  * Using a pointer after realloc is UB.
  1472ca52
- Rename functions to facilitate compilation of cdilib.c. · e30c5dcf
  Thomas Jahns authored 10 months ago
  
  e30c5dcf
- Rename to prevent clash when building cdilib.c. · 885b843a
  Thomas Jahns authored 10 months ago
  
  885b843a
- Move cast of size to delegate. · 10d14ddf
  Thomas Jahns authored 10 months ago
  
  10d14ddf
- Fix implicit conversions. · 23ba8ca8
  Thomas Jahns authored 10 months ago
  
  23ba8ca8
- Annotate unused parameter. · 53730c08
  Thomas Jahns authored 10 months ago
  
  53730c08
- Fix implicit casts. · e8403e2e
  Thomas Jahns authored 10 months ago
  
  e8403e2e
- Fix implicit casts. · 15b5ac56
  Thomas Jahns authored 10 months ago
  
  15b5ac56
- Comment currently unused parameter. · c37b78cc
  Thomas Jahns authored 10 months ago
  
  c37b78cc
- Eliminate effectively unused variable. · 056bf1ce
  Thomas Jahns authored 10 months ago
  
  056bf1ce
- Fix missing cast. · 94319868
  Thomas Jahns authored 10 months ago
  
  94319868
- Remove unused parameters. · f8ca63c3
  Thomas Jahns authored 10 months ago
  
  f8ca63c3
- Use already computed storage size. · 208f996c
  Thomas Jahns authored 10 months ago
  
  208f996c
- Fix incorrect cast. · 6213acc4
  Thomas Jahns authored 10 months ago
  
  6213acc4
- Shorten loops by eliding temporary. · 343dd1a6
  Thomas Jahns authored 10 months ago
  
  * Additional pointers complicate alias analysis.
  343dd1a6
- Make narrowing casts explicit. · 5b6fe88e
  Thomas Jahns authored 10 months ago
  
  5b6fe88e
- Use wider type for record and time step indexing. · 1c0310eb
  Thomas Jahns authored 10 months ago
  
  1c0310eb
- Annotate potential improvement. · 9901c1c8
  Thomas Jahns authored 10 months ago
  
  9901c1c8
- Remove redundant parameter. · a2ea9186
  Thomas Jahns authored 2 years ago
  
  * levels1 and levels2 already have a sentinel value.
  a2ea9186
- Fix build rule for make_fint. · 7d24a5eb
  Thomas Jahns authored 2 years ago
  
  * The previous version did not properly use libtool.
  7d24a5eb
- Fix generation of python SO with libtool. · 3cd64d9b
  Thomas Jahns authored 2 years ago
  
  3cd64d9b
- dont push: keep for later reference · 521588b8
  Thomas Jahns authored 2 years ago
  
  521588b8
- update cgribex · 231d6220
  Thomas Jahns authored 2 years ago
  
  231d6220
- Remove redundant clamping. · ece95ed2
  Thomas Jahns authored 2 years ago
  
  * The ternary above already ensures that datatype only takes values from the interval [1,32].
  ece95ed2
- Handle warning produced by gcc 4.9. · 3af0a03a
  Thomas Jahns authored 2 years ago
  
  3af0a03a
- Account for netCDF without HDF5 but with MPI. · d2c09104
  Thomas Jahns authored 2 years ago
  
  * It is possible to build netcdf 4.x without HDF5 but with MPI parallelization support.
  d2c09104
- Prevent redundant definition of HAVE_UNISTD_H. · 85dd592b
  Thomas Jahns authored 2 years ago
  
  85dd592b
- Use size_t for parameter used for indexing. · 23c0531f
  Thomas Jahns authored 2 years ago
  
  23c0531f
- Annotate unused parameters. · 0dbdf0b2
  Thomas Jahns authored 2 years ago
  
  0dbdf0b2
- Annotate incorrect compiler warning. · 59b1d62a
  Thomas Jahns authored 2 years ago
  
  59b1d62a
- Adjust parameter type. · 14f4909d
  Thomas Jahns authored 2 years ago
  
  * Using long yields larger range of consistent comparisons.
  14f4909d
- Annotate unproblematic warning from older compiler. · d580e96f
  Thomas Jahns authored 2 years ago
  
  d580e96f
- Do not play ping-pong with ALU and FPU. · e244d873
  Thomas Jahns authored 2 years ago
  
  * There is no need for moving data to memory to remove fraction bits.
  e244d873
- Replace loop with division. · a07a60f4
  Thomas Jahns authored 2 years ago
  
  a07a60f4
- Merge temporary buffers. · 6d2a0a78
  Thomas Jahns authored 2 years ago
  
  6d2a0a78
- Use failsafe malloc wrapper. · fd5edf54
  Thomas Jahns authored 2 years ago
  
  fd5edf54
- Clarify loop structure. · c4622614
  Thomas Jahns authored 2 years ago
  
  c4622614
- Use on-stack buffer when reasonable. · 8fd8f71c
  Thomas Jahns authored 2 years ago
  
  * Use failsafe malloc wrappers when not.
  8fd8f71c
- Use failsafe wrappers. · 01c73075
  Thomas Jahns authored 2 years ago
  
  01c73075
- Annotate future area of improval. · 09513b82
  Thomas Jahns authored 2 years ago
  
  09513b82
- Use failsafe malloc wrappers. · 4e5c0dc6
  Thomas Jahns authored 2 years ago
  
  4e5c0dc6
- Annotate, prevent or improve safety of narrowing conversions. · d12a6f9b
  Thomas Jahns authored 2 years ago
  
  d12a6f9b
- Consistently use size_t for nmissing. · 7e036074
  Thomas Jahns authored 2 years ago
  
  7e036074
- Remove unnecessary pointer indirection. · 2db1c258
  Thomas Jahns authored 2 years ago
  
  2db1c258
- Disentangle hard to combine features. · beb8bffd
  Thomas Jahns authored 2 years ago
  
  beb8bffd
- Conditionally compile interface to optional dependency. · cf886f71
  Thomas Jahns authored 2 years ago
  
  cf886f71
- Use failsafe malloc wrappers. · d9892612
  Thomas Jahns authored 2 years ago
  
  d9892612
- Merge temporary allocations. · 62355cb8
  Thomas Jahns authored 2 years ago
  
  62355cb8
- Use long for grib editionNumber field. · 79f38e15
  Thomas Jahns authored 2 years ago
  
  79f38e15
- Use failsafe malloc wrappers. · 8ca45db3
  Thomas Jahns authored 2 years ago
  
  8ca45db3
- Clarify function. · a9a6eee7
  Thomas Jahns authored 2 years ago
  
  a9a6eee7
- Use temporaries to shorten expression. · 162ee649
  Thomas Jahns authored 2 years ago
  
  * Also use failsafe wrappers for malloc.
  162ee649
- Use wider type for time step indexing. · 035c3ac2
  Thomas Jahns authored 2 years ago
  
  035c3ac2
- Remove no longer supported substitution. · 15426291
  Thomas Jahns authored 10 months ago
  
  15426291
- Prefer size_t for buffer sizes and indexing. · 503450da
  Thomas Jahns authored 2 years ago
  
  503450da
- Annotate unused arguments. · 8bb42636
  Thomas Jahns authored 2 years ago
  
  * These are mostly due to conditional compilation.
  8bb42636
- Use narrowing for bit ops on narrow types. · 1926771d
  Thomas Jahns authored 2 years ago
  
  * C automatically expands such expressions to int.
  1926771d
- Use same type as RHS of expression. · 3b7cf867
  Thomas Jahns authored 2 years ago
  
  3b7cf867
- Use int for grid ID. · ec59d44f
  Thomas Jahns authored 2 years ago
  
  ec59d44f
- Use full word size. · c1c2af26
  Thomas Jahns authored 2 years ago
  
  c1c2af26
- Prefer int64_t since only caller uses that. · b33bf237
  Thomas Jahns authored 2 years ago
  
  b33bf237
- Always include config.h. · 7e8f77cb
  Thomas Jahns authored 2 years ago
  
  * The macros defined in config.h might change size of off_t, symbols available from system headers etc. This effect will vary from system to system even.
  7e8f77cb
- Use explict type conversions for size_t/SizeType/double. · ff1b685d
  Thomas Jahns authored 2 years ago
  
  ff1b685d
- Prevent unnecessary whitespace. · 7cdc65ba
  Thomas Jahns authored 2 years ago
  
  7cdc65ba
- Fix incorrect JSON. · f0d3a543
  Thomas Jahns authored 2 years ago
  
  f0d3a543
- Use SizeType where reasonably feasible. · 5521562a
  Thomas Jahns authored 2 years ago
  
  5521562a
- Make implicit, potentially value-changing conversions explicit. · e426bbde
  Thomas Jahns authored 2 years ago
  
  e426bbde
- Rename externally visible function. · 9ff2e086
  Thomas Jahns authored 2 years ago
  
  9ff2e086
- Add alternative code path for huge buffers. · 03988d32
  Thomas Jahns authored 2 years ago
  
  * In practice indexing into RMA buffers may require 64bit addressing, even though individual data sets are still limited to INT_MAX entries.
  03988d32
- Transfer data over RMA with larger element datatype. · e4355dc5
  Thomas Jahns authored 2 years ago
  
  e4355dc5
- Refine test for optional NetCDF feature. · 9e0797d4
  Thomas Jahns authored 2 years ago
  
  9e0797d4

Miscellaneous fixes and CDI-PIO improvements

Merge request reports

Activity