Skip to content
Snippets Groups Projects

CMake: reduce minimum version

Merged Mathieu Westphal requested to merge b383306/libcdi:reduce_minimum_cmake_version into develop
1 unresolved thread

Tested locally on windows/mac/linux.

It could probably be reduced further, but I did not test it.

Edited by Mathieu Westphal

Merge request reports

Merge request pipeline #96697 passed

Merge request pipeline passed for 932dd558

Approval is optional

Merged by Uwe SchulzweidaUwe Schulzweida 1 month ago (Feb 14, 2025 12:29pm UTC)

Merge details

  • Changes merged into develop with 932dd558.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #97060 passed

Pipeline passed for 932dd558 on develop

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mathieu Westphal changed the description

    changed the description

  • Author Contributor

    @m214003 @m300433 please review. The pipeline is not working for me for some reason.

  • Uwe Schulzweida enabled an automatic merge when all merge checks for 932dd558 pass

    enabled an automatic merge when all merge checks for 932dd558 pass

    • Why should we downgrade the cmake version? @b383306

    • Author Contributor

      Well, you want to set the minimum version to the oldest possible, because if not you are forcing the system compiling libcdi to update their CMake for no reason.

      The way I do it generally is by downloading a bunch of CMake version and configuring the project with the oldest and oldest version of CMake until I find the one that do not work.

      In that specific case I just reduced it to my needs (the ParaView superbuild is using CMake 3.27) but it probably only needs CMake 3.0

    • The CMake of libcdi is currently being developed. Internally I was asked to finish or at least push what I have at the end of this month. The current state is on the branch: m300433/cmake_improvements_and_define_cleanups Uwe told me that you were interested in libcdi in context of CMake and I am looking forward to your input, especially since I have not yet started on the installation of libcdi via CMake. But please give me a week or two before starting to change things or instruct me how to do it. A set of your requirements would be very welcome of course. In context of the version: I was not aware that CMake 3.30 is only ~7 months old.

      Edited by Oliver Heidmann
    • Author Contributor

      I have not yet started on the installation of libcdi via CMake.

      I did that already, Ill be happy to share my code next week.

      Uwe told me that you were interested in libcdi in context of CMake

      Definitely!

      A set of your requirements would be very welcome of course.

      I want to be able to ship the CDIReader plugin in ParaView Windows, which require full cmake support for the lib.

    • Please register or sign in to reply
Please register or sign in to reply
Loading