Thomas Jahns authored 5 years ago and Sergey Kosukhin committed 2 years ago

* This also allows for overrides at make invocation.

Thomas Jahns authored 5 years ago and Sergey Kosukhin committed 2 years ago

* When CXX=CC and FC=ftn are used simultaneously on a CCE 8.7 system,
  ftn inherits the output_verbose_link_cmd as postdeps from the C++
  tests and everything goes wrong afterwards even for non-shared
  archives.

Thomas Jahns authored 5 years ago and Sergey Kosukhin committed 2 years ago

* This was needed to get working builds on Piz Daint, libtool 2.4.2 generated
  bogus dependencies on libquadmath.so.

Thomas Jahns authored 5 years ago and Sergey Kosukhin committed 2 years ago

* Apparently craycc also makes some optimistic assumptions about the effect
  of comparing -0.0 to 0.0.

Thomas Jahns authored 5 years ago and Sergey Kosukhin committed 2 years ago

* For some reason gcc 9.1 does not detect that status is never used
  uninitialized.

Thomas Jahns authored 5 years ago and Sergey Kosukhin committed 2 years ago

* Given how many lines documenting the confusing pattern and how many
  compiler warnings are eliminated by this change...

Thomas Jahns authored 5 years ago and Sergey Kosukhin committed 2 years ago

* There is no caller for the newly removed function stubs anyway.

Thomas Jahns authored 5 years ago and Sergey Kosukhin committed 2 years ago

* GCC 8.x and newer warn about the previously used "void (*)()", use
  "void (*)(void)" instead.

Thomas Jahns authored 5 years ago and Sergey Kosukhin committed 2 years ago

* collSpec is meant to be a dumb data collection, none of its member should
  be subject to change.

Thomas Jahns authored 6 years ago and Sergey Kosukhin committed 2 years ago

* gcc 6.4 does not realize posix_memalign initializes ptr on some
  Linux systems.

Thomas Jahns authored 6 years ago and Sergey Kosukhin committed 2 years ago

* The previous implementation had the destructor also release the mapping.

* That was problematic, because the internals of objects depended on
  the external mapping unnecessarily.

* This also fixes a potential double-free issue discovered by Jan
  Frederik Engels.