Remove effectively unused return value.

src/pio_dbuffer.c

@@ -19,7 +19,7 @@
 #include "pio_dbuffer.h"
 #include "pio_util.h"
 
-int
+void
 cdiPioDbufferInit(struct dBuffer *db, size_t bufSize)
 {
   assert(db);
@@ -57,7 +57,6 @@ cdiPioDbufferInit(struct dBuffer *db, size_t bufSize)
   db->buffer = (unsigned char *) malloc(bufSize);
   assert(db->buffer);
 #endif
-  return 0;
 }
 
 void

src/pio_dbuffer.h

@@ -12,7 +12,7 @@ struct dBuffer
   unsigned char *buffer;
 };
 
-int cdiPioDbufferInit(struct dBuffer *dbuffer, size_t bufSize);
+void cdiPioDbufferInit(struct dBuffer *dbuffer, size_t bufSize);
 bool cdiPioDbufferAppend(struct dBuffer *dbuffer, const void *data, size_t dataLen);
 void cdiPioDbufferDestroy(struct dBuffer *dbuffer);
 

src/pio_mpinonb.c

@@ -45,10 +45,7 @@ initAFiledataMPINONB(struct fileMPIFWS *of, const char *filename, size_t bufSize
   }
 
   /* init output buffer */
-  int iret = cdiPioDbufferInit(of->db, bufSize);
-  iret += cdiPioDbufferInit(of->db + 1, bufSize);
-
-  if (iret > 0) xabort("cdiPioDbufferInit did not succeed");
+  for (size_t dbufIdx = 0; dbufIdx < 2; ++dbufIdx) cdiPioDbufferInit(of->db + dbufIdx, bufSize);
 
   of->dbufIdx = 0;
 

src/pio_posixfpguardsendrecv.c

@@ -68,9 +68,7 @@ newMultiwriterFileBuf(struct mwFileBuf *afd, const char *filename, size_t bs)
 
   xdebug(" name=%s, init output buffer", afd->name);
 
-  int iret = cdiPioDbufferInit(&afd->db, bs);
-
-  if (iret > 0) xabort("cdiPioDbufferInit did not succeed");
+  cdiPioDbufferInit(&afd->db, bs);
 
   /* open file */
   xdebug("name=%s, open file", afd->name);

src/pio_posixnonb.c

@@ -51,8 +51,7 @@ initBFiledataP(struct fileFunnelStdio *bfp, const char *filename, size_t bs, siz
   if ((bfp->fp = fopen(filename, "w")) == NULL) xabort("Failed to open %s", bfp->name);
 
   struct dBuffer *db = bfp->db = Malloc(sizeof(*db) * nc);
-  int iret = 0;
-  for (size_t i = 0; i < nc; ++i) iret += cdiPioDbufferInit(db + i, bs);
+  for (size_t i = 0; i < nc; ++i) cdiPioDbufferInit(db + i, bs);
   bfp->offset = 0;
   bfp->syncOffset = 0;
   bfp->activeCollectors = (int) nc;

src/pio_record_send.c

@@ -52,12 +52,9 @@ initRemoteFileBuf(struct remoteFileBuf *restrict rfile, const char *filename, si
 
   xdebug("filename=%s, init output buffer", filename);
 
-  int iret = 0;
-  for (size_t i = 0; i < numRecordSendBuf; ++i) iret += cdiPioDbufferInit(rfile->dbuf + i, bs);
+  for (size_t i = 0; i < numRecordSendBuf; ++i) cdiPioDbufferInit(rfile->dbuf + i, bs);
   for (size_t i = 0; i < numRecordSendBuf + numFlushOp; ++i) rfile->request[i] = MPI_REQUEST_NULL;
 
-  if (iret > 0) xabort("cdiPioDbufferInit did not succeed");
-
   rfile->dbufIdx = 0;
 
   xdebug("added name=%s, return", rfile->name);