Commit 358ea982 authored by Uwe Schulzweida's avatar Uwe Schulzweida
Browse files

some FIXME comments [patch 4 from Nathanael]

parent 7233a455
......@@ -841,7 +841,7 @@ int tableInqParName(int tableID, int code, char *varname)
if ( parTable[tableID].pars[item].id == code )
{
if ( parTable[tableID].pars[item].name )
strcpy(varname, parTable[tableID].pars[item].name);
strcpy(varname, parTable[tableID].pars[item].name); //FIXME: This may overrun the supplied buffer!
break;
}
}
......
......@@ -1176,6 +1176,7 @@ void vlistDefTaxis(int vlistID, int taxisID)
if (vlistptr->taxisID != taxisID)
{
//FIXME: This code seems to leak a taxis_t object if `vlistptr->taxisID` was valid before the call to vlistDefTaxis.
vlistptr->taxisID = taxisID;
reshSetStatus(vlistID, &vlistOps, RESH_DESYNC_IN_USE);
}
......
......@@ -496,7 +496,7 @@ void vlistInqVarName(int vlistID, int varID, char *name)
}
}
else
strcpy(name, vlistptr->vars[varID].name);
strcpy(name, vlistptr->vars[varID].name); //FIXME: This may overrun the provided buffer.
return;
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment