Skip to content
Snippets Groups Projects

M300433/number conversion improvement

Merged Oliver Heidmann requested to merge m300433/number_conversion_improvement into develop

When implementing the conversion functions std::numeric_limits::quite_Nan() was used. Since this Nan is only defined for floating point types the implementation was wrong. When adding the tests contained in this PR this was found and fixed.

  • added tests for handling of empty strings
  • split number conversion into two functions (integral/floating)
  • added exception on wrong conversion
  • the two new functions catch this exceptions and return ::max() for integral and ::quite_Nan for floating point representations

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading