Granule driver and data checker updated
This merge request contains an updated version of the granule_run subroutine driver and a newly created "data checker" which can be used to compare the output of independent granule_run execution (for example from a full ICON run and a driver based run). Instructions are provided in the README file.
Merge request reports
Activity
requested review from @m214002
assigned to @m300369
Hi @m300369 , @b381714 , I was not able to run this code on Levante, so I could only compare old and new code, and did this for mo_aes_thermo.f90 and mo_aes_graupel.f90 only. The two changed lines in mo_aes_thermo.f90 are already in the original code (in icon-mpim). Concerning mo_aes_graupel.f90: I really like the removal of distracting spaces and the correction of incorrect indentation. But when comparing old against new or original against copy, it is very annoying. Without these corrections, it is clear what has really been changed. I would therefore not mix such changes. Synchronization with the code in the main repository will be a bit harder with these changes. Otherwise, that's fine with me. Whether you change it back or not is still up to you.
And unfortunately I cannot comment on the rest of the code changes. So I can only approve the two mo_aes-routines.
added 1 commit
- 25011879 - Mix of fs_ and ftg_ module removed, only fs_ module is now used
added 1 commit
- 1ab92c1f - Serialized mo_aes_graupel.f90 renamed as mo_aes_graupel_ser.f90
added 1 commit
- 33ddb6d8 - Serialized mo_aes_graupel.f90 renamed as mo_aes_graupel_ser.f90
added 1 commit
- 2a4203cd - Driver/Data checker specific README_driver.md file created to avoid merge conflicts
added 1 commit
- ddd89537 - Existing original graupel_driver restored and CMake updated
added 40 commits
-
ddd89537...f8ecd7e3 - 39 commits from branch
main - 5e07d06a - Merge branch 'main' into driver_and_checker
-
ddd89537...f8ecd7e3 - 39 commits from branch
Christopher has gone a long way to removing the potential conflicts of this version in order to allow it to be merged all the way back into icon-mpim. Basically all the complexity of generating the serialbox files and using the serialbox_driver code is now documented in README_serialbox_driver.md, separate from the original README.md. If @m214002 agrees, I will simply merge driver_and_checker into the main branch.