Skip to content
Snippets Groups Projects

Fixed installation; other projects can now find module files from iconmath

Merged Pradipta Samanta requested to merge k202170-fix-make-install into main
All threads resolved!

What is the bug

Any projects dependent on libiconmath were not able to find the associated module files when libiconmath was installed in the system. Additionally, the use of an install_prefix was not supported.

How do you fix it

CMAKE_INSTALL_PREFIX was not used to define INSTALL_INTERFACE. I corrected it now.

How urgent is the bugfix

  • I need it as soon as possible
  • I can wait for a couple of days
  • None of my current codes is directly affected

Mandatory steps before review

  • Gitlab CI passes (Hint: use make format for linting)
  • Bugfix is covered by additional unit tests
  • Mark the merge request as ready by removing Draft:

Mandatory steps before merge

  • Reviewed by a maintainer
  • Incorporate review suggestions
  • Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain

You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!

Edited by Pradipta Samanta

Merge request reports

Pipeline #81955 passed

Pipeline passed for 19ffae13 on k202170-fix-make-install

Merged by Yen-Chen ChenYen-Chen Chen 7 months ago (Sep 23, 2024 1:11pm UTC)

Loading

Pipeline #81973 passed

Pipeline passed for 588c8f95 on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 4 commits

    • 3cf7ee6f - 1 commit from branch main
    • 42933ac8 - Made 'make install' work when CMAKE_INSTALL_PREFIX is used during configuration
    • ebbfb54f - fixed the gitignore file
    • 19ffae13 - Fixed the gitignore file by replacing *.txt by a specific file name

    Compare with previous version

  • Yen-Chen Chen approved this merge request

    approved this merge request

  • Yen-Chen Chen resolved all threads

    resolved all threads

  • mentioned in commit 588c8f95

  • Please register or sign in to reply
    Loading