Fixed the cmake-style check in gitlab-ci
All threads resolved!
All threads resolved!
What is the bug
The CMake style check in GitLab CI was not applied to all relevant files
How do you fix it
Use wildcard expression to prevent missing new files in the future.
How urgent is the bugfix
-
I need it as soon as possible -
I can wait for a couple of days -
None of my current codes is directly affected
Mandatory steps before review
-
Gitlab CI passes (Hint: use make format
for linting) -
Bugfix is covered by additional unit tests -
Mark the merge request as ready by removing Draft:
Mandatory steps before merge
-
Reviewed by a maintainer -
Incorporate review suggestions -
Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain
You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!
Edited by Yen-Chen Chen
Merge request reports
Activity
requested review from @b382190
assigned to @k202170
- Resolved by Yen-Chen Chen
libiconmath/CMakeLists.txt
is not formatted. See https://gitlab.dkrz.de/icon-libraries/libiconmath/-/jobs/439382
added 1 commit
- cb80c04b - ci: removed double asterisk to find all CMakeLists.txt; does not work in CI
mentioned in commit edc6158b
Please register or sign in to reply