Draft: Do dot product with Kokkos subview

What is the new feature

Replace ugly expanded dot product with std::inner_product using Kokkos subviews.

How is it implemented

Get vector by Kokkos subview, which can be passed in std::inner_product.

The advantage is

1. No lambda functions, no extra wrapper class.
2. Readable code

The disadvantage is

1. Use functions of Kokkos::Experimental (iterators), which might need to be updated with future Kokkos versions.
2. No guarantee of performance.

Mandatory steps before review

• Gitlab CI passes (Hint: use make format for linting)
• New feature is covered by additional unit tests
• Mark the merge request as ready by removing Draft:

Mandatory steps before merge

• Reviewed by a maintainer
• Incorporate review suggestions
• Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
• Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain

You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!

src/horizontal/lib_divrot.cpp

@@ -408,28 +408,28 @@ void recon_lsq_cell_q_svd(const T *p_cc, const int *lsq_idx_c,
           auto lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 4, std::make_pair(0, 9), jb);
           p_coeff_view(5, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_pseudoinv_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b_subview), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b_subview), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 3, std::make_pair(0, 9), jb);
           p_coeff_view(4, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_pseudoinv_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b_subview), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b_subview), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 2, std::make_pair(0, 9), jb);
           p_coeff_view(3, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_pseudoinv_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b_subview), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b_subview), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 1, std::make_pair(0, 9), jb);
           p_coeff_view(2, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_pseudoinv_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b_subview), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b_subview), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 0, std::make_pair(0, 9), jb);
           p_coeff_view(1, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_pseudoinv_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b_subview), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b_subview), 0.0);
           p_coeff_view(0, jc, jk, jb) =
               p_cc_view(jc, jk, jb) -
               p_coeff_view(1, jc, jk, jb) * lsq_moments_view(jc, jb, 0) -
@@ -733,48 +733,48 @@ void recon_lsq_cell_c_svd(const T *p_cc, const int *lsq_idx_c,
           auto lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 8, std::make_pair(0, 9), jb);
           p_coeff_view(9, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_qtmat_c_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 7, std::make_pair(0, 9), jb);
           p_coeff_view(8, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_qtmat_c_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 6, std::make_pair(0, 9), jb);
           p_coeff_view(7, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_qtmat_c_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 5, std::make_pair(0, 9), jb);
           p_coeff_view(6, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_qtmat_c_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 4, std::make_pair(0, 9), jb);
           p_coeff_view(5, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_qtmat_c_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 3, std::make_pair(0, 9), jb);
           p_coeff_view(4, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_qtmat_c_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 2, std::make_pair(0, 9), jb);
           p_coeff_view(3, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_qtmat_c_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 1, std::make_pair(0, 9), jb);
           p_coeff_view(2, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_qtmat_c_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b), 0.0);
           lsq_pseudoinv_subview =
               subview(lsq_pseudoinv_view, jc, 0, std::make_pair(0, 9), jb);
           p_coeff_view(1, jc, jk, jb) = std::inner_product(
-              KE::cbegin(lsq_qtmat_c_subview), KE::cend(lsq_qtmat_c_subview),
-              KE::cbegin(z_b), 0.0);
+              KE::cbegin(lsq_pseudoinv_subview),
+              KE::cend(lsq_pseudoinv_subview), KE::cbegin(z_b), 0.0);
           p_coeff_view(0, jc, jk, jb) =
               p_cc_view(jc, jk, jb) -
               p_coeff_view(1, jc, jk, jb) * lsq_moments_view(jc, jb, 0) -