Skip to content
Snippets Groups Projects

Fix wrong parsing argument starting index N

Merged Yen-Chen Chen requested to merge fix_cmake into main

What is the bug

The staring index of cmake_parse_argument is wrong in two functions

How do you fix it

Fix the starting index N.

How urgent is the bugfix

  • I need it as soon as possible
  • I can wait for a couple of days
  • None of my current codes is directly affected

Mandatory steps before review

  • Gitlab CI passes (Hint: use make format for linting)
  • Bugfix is covered by additional unit tests
  • Mark the merge request as ready by removing Draft:

Mandatory steps before merge

  • Reviewed by a maintainer
  • Incorporate review suggestions
  • Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain

You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!

Edited by Pradipta Samanta

Merge request reports

Pipeline #78728 passed

Pipeline passed for 751e13e8 on fix_cmake

Merged by Pradipta SamantaPradipta Samanta 8 months ago (Aug 23, 2024 2:22pm UTC)

Loading

Pipeline #78729 passed

Pipeline passed for bb2040d4 on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading