Added C++ version of the routines of mo_lib_intp_rbf
What is the new feature
The routines in mo_lib_intp_rbf are ported to C++
How is it implemented
Kokkos is used to manage the memory and the for loops
Mandatory steps before review
-
Gitlab CI passes (Hint: use make format
for linting) -
New feature is covered by additional unit tests -
Mark the merge request as ready by removing Draft:
Mandatory steps before merge
-
Reviewed by a maintainer -
Incorporate review suggestions -
Remember to edit the commit message and select the proper changelog category (feature/bugfix/other) -
Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain
You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!
Edited by Pradipta Samanta
Merge request reports
Activity
requested review from @k202170
assigned to @k202194
added 38 commits
-
15fb7bf1...e4efb896 - 37 commits from branch
feature-add-cpp-codes
- 37ca4777 - Merge branch 'feature-add-cpp-codes' into 'feature_add_cpp_codes_interpolation_Ali'
-
15fb7bf1...e4efb896 - 37 commits from branch
added 49 commits
-
9efe7dc2...e4efb896 - 37 commits from branch
feature-add-cpp-codes
- e4efb896...cfeadc0d - 2 earlier commits
- eb07d71c - fixed typo!
- 2e05ecc8 - added binding file into cmake
- 42abe03c - Fixed typo
- a99da130 - Ported rbf_interpol_c2grad_lib
- 7bb1ae03 - Added grad_y
- 9f00d8df - Ported rbf_vec_interpol_cell_lib
- 11aa5765 - Ported rbf_vec_interpol_edge_lib
- 0ce39a59 - Fixed index
- 768b5176 - ported mo_lib_laplace
- 4122a81a - Fixed index for nabla2_scalar_lib
Toggle commit list-
9efe7dc2...e4efb896 - 37 commits from branch
added 63 commits
-
8a6c4bb6...b7483a4d - 39 commits from branch
feature-add-cpp-codes
- b7483a4d...4f0ea438 - 14 earlier commits
- 732769bc - Revert "Fixed index for nabla2_scalar_lib"
- c115d9d0 - Revert "ported mo_lib_laplace"
- 6a1c7103 - modified few things in the existing test for intp_rbf
- 8dadd736 - fixed few bugs in one of the routine of intp_rbf
- 06cf4132 - added a unit-test for rbf_interpol_c2grad_lib
- 6db33cd5 - Rbf clean up
- 1be0c3ab - Fix
- 0f5a6e75 - Added test for cell_lib
- 8175944d - Fixed strange typo
- 3afe4ffe - Added test for edge_lib
Toggle commit list-
8a6c4bb6...b7483a4d - 39 commits from branch
added 7 commits
- 9d414e59 - put the instantiations at the end of the file
- a3e149a6 - moved intp_rbf routines from the temporary file to the main file
- f0f19514 - deleted intp_rbf_bindings and merged its contents into interpolation_bindings
- ed5c21b6 - made changes to test_intp_rbf
- eb4096e1 - made few changes to test_interpolation_scalar
- 1d49b1bd - formatted the c codes using clang-format
- 2cbc4234 - added some comments to the bindings
Toggle commit listadded 2 commits
Please register or sign in to reply