Draft: adding cpp version of codes (!22) · Merge requests · icon-libraries / libiconmath

Open Pradipta Samanta requested to merge feature-add-cpp-codes into main 3 months ago

Apr 23, 2025

Fix the failing of unit tests with -O0 in test_interpolation_scalar (!53 ) · 3cc1b690

Pradipta Samanta authored 1 week ago and

Yen-Chen Chen committed 1 week ago


## What is the bug
All the unit tests in test_interpolation_scalar were failing when the code is compiled without any optimization
## How do you fix it
Needed to use `static constexpr` while defining start and end indices

Merged-by: Yen-Chen Chen <yen-chen.chen@tum.de>
Changelog: bugfix

3cc1b690

Apr 17, 2025

Fix ambiguous call of constexpr variables (!51 ) · 62c21c2a

Yen-Chen Chen authored 2 weeks ago and

Pradipta Samanta committed 2 weeks ago


## What is the bug
Some compilers (for example, Apple clang, LLVM clang) cannot figure out the constexpr members of a templated class if they are not specialized.
## How do you fix it
Use specialized member references instead of `this`.

Merged-by: Pradipta Samanta <samanta@dkrz.de>
Changelog: bugfix

62c21c2a

Apr 16, 2025
- Fix GPU unit tests (!46 ) · 7e72fd0c
  Pradipta Samanta authored 2 weeks ago
  
  7e72fd0c
- Update googletest version (!44 ) · 17066363
  Yen-Chen Chen authored 1 month ago and Pradipta Samanta committed 2 weeks ago
  
  ## What is the new feature Update googletest version. The old v1.12.1 uses a deprecated CMake minimum version. ## How is it implemented Update the download version in FetchContent Merged-by: Pradipta Samanta <samanta@dkrz.de> Changelog: feature
  17066363
- Implement C++ code for divrot (!33 ) · 74819211
  Yen-Chen Chen authored 1 month ago and Pradipta Samanta committed 2 weeks ago
  
  ## What is the new feature Implement C++ functions for the Fortran `mo_divrot` module ## How is it implemented This first version is implemented using simple templated functions with Kokkos Co-authored-by: Pradipta Samanta <samanta@dkrz.de> Merged-by: Pradipta Samanta <samanta@dkrz.de> Changelog: feature
  74819211
- Added C++ version of the routines of mo_lib_intp_rbf (!35 ) · a9f3bb03
  Ali Sedighi authored 1 month ago and Pradipta Samanta committed 2 weeks ago
  
  ## What is the new feature The routines in mo_lib_intp_rbf are ported to C++ ## How is it implemented Kokkos is used to manage the memory and the for loops Co-authored-by: Pradipta Samanta <samanta@dkrz.de> Merged-by: Pradipta Samanta <samanta@dkrz.de> Changelog: feature
  a9f3bb03
- First Kokkos version of 'mo_lib_interpolation_scalar' (!36 ) · 60f00ef4
  Harshada Balasubramanian authored 1 month ago and Pradipta Samanta committed 2 weeks ago
  
  Co-authored-by: Pradipta Samanta <samanta@dkrz.de> Co-authored-by: Dylan Kierans <kierans@dkrz.de> Merged-by: Pradipta Samanta <samanta@dkrz.de> Changelog: feature
  60f00ef4
- cpp version of mo_lib_intp_rbf::rbf_vec_interpol_vertex_lib (!34 ) · bee83973
  Dylan Kierans authored 2 months ago and Pradipta Samanta committed 2 weeks ago
  
  ## What is the new feature cpp version of mo_lib_intp_rbf::rbf_vec_interpol_vertex_lib ## How is it implemented Kept separate file from other `mo_lib_intp_rbf` routines to avoid merge conflicts. Will be resolved by Ali and Dylan later. Co-authored-by: Pradipta Samanta <samanta@dkrz.de> Merged-by: Pradipta Samanta <samanta@dkrz.de> Changelog: feature
  bee83973
- Added a new argument to the functions of `mo_lib_loopindices.cpp` to fix a bug... · b7f64994
  Harshada Balasubramanian authored 2 months ago and Pradipta Samanta committed 2 weeks ago
  
  Added a new argument to the functions of `mo_lib_loopindices.cpp` to fix a bug regarding startindex (!32) This made the code to produce bit-identical results for both Fortran and C++ Co-authored-by: Pradipta Samanta <samanta@dkrz.de> Merged-by: Pradipta Samanta <samanta@dkrz.de> Changelog: bugfix
  b7f64994
- added openacc_fortran_options only for the compilation of Fortran codes · 76e93e73
  Pradipta Samanta authored 2 months ago
  
  fixed a cmake style added to two other components
  76e93e73
- configure compilation for kokkos + nvidia (!31 ) · 6e661871
  Georgiana Mania authored 2 months ago and Pradipta Samanta committed 2 weeks ago
  
  Merged-by: Pradipta Samanta <samanta@dkrz.de> Changelog: default
  6e661871
- modified CMakeLists.txt of horizontal to enable compilation of C++ code that uses Kokkos · c7d6331b
  Pradipta Samanta authored 2 months ago
  
  c7d6331b
- added licence to the new test file · a11f34af
  Pradipta Samanta authored 2 months ago
  
  a11f34af
- added test for interpolation_vector · b02fa263
  Pradipta Samanta authored 2 months ago
  
  b02fa263
- fixed a bug in cmake style · b67cd320
  Pradipta Samanta authored 2 months ago
  
  b67cd320
- added license to the new files · e22f0d6d
  Pradipta Samanta authored 2 months ago
  
  e22f0d6d
- added c++ code for mo_lib_interpolation_vector · 7f11b76f
  Pradipta Samanta authored 2 months ago
  
  7f11b76f
- added unit-tests for c++ codes using googletest · 4d760ecf
  Pradipta Samanta authored 2 months ago
  
  4d760ecf
- made the cpp function a templated one · 743afdfa
  Pradipta Samanta authored 2 months ago
  
  743afdfa
- updated the gitignore file · 7f30d138
  Pradipta Samanta authored 2 months ago
  
  7f30d138
- fixed an error in cmake styling · d14847eb
  Pradipta Samanta authored 2 months ago
  
  d14847eb
- changed cmake format · 4070f488
  Pradipta Samanta authored 2 months ago
  
  4070f488
- build kokkos internally along with the package · fe8b0da6
  Pradipta Samanta authored 2 months ago
  
  fe8b0da6
- converted the c++ code in mo_math_utilities to Kokkos · 215e067f
  Pradipta Samanta authored 2 months ago
  
  215e067f
- enabled compilation using Kokkos · 60d06471
  Pradipta Samanta authored 2 months ago
  
  60d06471
- added licences to the new cpp files · e1782b0c
  Pradipta Samanta authored 3 months ago
  
  e1782b0c
- fixed further style formatting issues · 0d73c3a5
  Pradipta Samanta authored 3 months ago
  
  0d73c3a5
- fixed a style formatting issue · 8670de7e
  Pradipta Samanta authored 3 months ago
  
  8670de7e
- updated the extension of test_math_utilities · c17b1d3e
  Pradipta Samanta authored 3 months ago
  
  c17b1d3e
- added an additional test for tdma_solver_vec · 5f0d5da4
  Pradipta Samanta authored 3 months ago
  
  5f0d5da4
- added nrows and ncols as arguments to the cpp routine of tdma_solver_vec · 97e50c3d
  Pradipta Samanta authored 3 months ago
  
  97e50c3d
- change the place of start the timer · e09e45c5
  Pradipta Samanta authored 3 months ago
  
  e09e45c5
- replaced the lambda function for calculating combined index with a macro function · 613c3eaf
  Pradipta Samanta authored 3 months ago
  
  fixed a bug
  613c3eaf
- changed the way local arrays are defined, it improves the performance · 17850cb2
  Pradipta Samanta authored 3 months ago
  
  fixed a bug
  17850cb2
- added the test for the cpp binding of tdma_solver_vec · ee7afb79
  Pradipta Samanta authored 3 months ago
  
  fixed a bug in testing
  ee7afb79
- added the cpp version of tdma_solver_vec · 11857257
  Pradipta Samanta authored 3 months ago
  
  made it compile
  11857257
- enabled the use of cpp bindings for mo_lib_loopindices · da18a6eb
  Pradipta Samanta authored 4 months ago
  
  da18a6eb
- added the cpp version of mo_lib_loopindices and compiled the code · 7d99c5ac
  Pradipta Samanta authored 4 months ago
  
  made changes to debug the last version
  7d99c5ac
- changed the extension of mo_lib_loopindices to F90 · 17535768
  Pradipta Samanta authored 4 months ago
  
  17535768
- updated the gitignore file · a1008e61
  Pradipta Samanta authored 4 months ago
  
  a1008e61
- fixed a style-check issue · 5f3f06d2
  Pradipta Samanta authored 2 months ago
  
  5f3f06d2
- updated the gitignore file · 427a3367
  Pradipta Samanta authored 4 months ago
  
  427a3367
- added unittests for mo_math_utilities, partially done · e17cc455
  Pradipta Samanta authored 4 months ago
  
  e17cc455
- added unittests for mo_lib_loopindices · dab8c246
  Pradipta Samanta authored 4 months ago
  
  dab8c246

Draft: adding cpp version of codes

What is the new feature

Mandatory steps before review

Mandatory steps before merge

Activity

Draft: adding cpp version of codes

What is the new feature

Mandatory steps before review

Mandatory steps before merge

Merge request reports

Activity