Skip to content

Fix CMake install path not taking environmental path

Yen-Chen Chen requested to merge fix_cmake_install into main

What is the bug

CMake install path needs to be defined explicitly and thus hard to cooperate with upperlayer repositories. Also see libfortran-support!103 (merged)

How do you fix it

Use $<INSTALL_PREFIX> instead of ${CMAKE_INSTALL_PREFIX}

How urgent is the bugfix

  • I need it as soon as possible
  • I can wait for a couple of days
  • None of my current codes is directly affected

Mandatory steps before review

  • Gitlab CI passes (Hint: use make format for linting)
  • Bugfix is covered by additional unit tests
  • Mark the merge request as ready by removing Draft:

Mandatory steps before merge

  • Reviewed by a maintainer
  • Incorporate review suggestions
  • Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
  • Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain

You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!

Edited by Pradipta Samanta

Merge request reports

Loading