Skip to content
Snippets Groups Projects

Added the option im_enable_openmp to compile the library with the openmp flag

Merged Pradipta Samanta requested to merge feature-enable-openmp into main

What is the new feature

The library now compiles OpenMP codes even when the OpenMP flag is not added manually in CMAKE_Fortran_FLAGS

How is it implemented

Added the option IM_ENABLE_OPENMP, checked whether OpenMP is available as a package and added the flags in the existing Fortran_FLAGS

Mandatory steps before review

  • Gitlab CI passes (Hint: use make format for linting)
  • New feature is covered by additional unit tests
  • Mark the merge request as ready by removing Draft:

Mandatory steps before merge

  • Reviewed by a maintainer
  • Incorporate review suggestions
  • Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain

You are not supposed to merge this request by yourself, the maintainers of libiconmath take care of this action!

Edited by Yen-Chen Chen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Yen-Chen Chen requested changes

    requested changes

  • added 2 commits

    • 9742011f - ci: changed the name of the stage in CI related to openmp
    • 88718789 - build: removed the strict requirement while finding the package OpenMP

    Compare with previous version

  • Pradipta Samanta requested review from @b382190

    requested review from @b382190

  • Yen-Chen Chen resolved all threads

    resolved all threads

  • Yen-Chen Chen marked the checklist item Gitlab CI passes (Hint: use make format for linting) as completed

    marked the checklist item Gitlab CI passes (Hint: use make format for linting) as completed

  • Yen-Chen Chen marked the checklist item New feature is covered by additional unit tests as completed

    marked the checklist item New feature is covered by additional unit tests as completed

  • Yen-Chen Chen marked the checklist item Mark the merge request as ready by removing Draft: as completed

    marked the checklist item Mark the merge request as ready by removing Draft: as completed

  • Yen-Chen Chen marked the checklist item Reviewed by a maintainer as completed

    marked the checklist item Reviewed by a maintainer as completed

  • Yen-Chen Chen marked the checklist item Incorporate review suggestions as completed

    marked the checklist item Incorporate review suggestions as completed

  • Yen-Chen Chen marked the checklist item Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain as completed

    marked the checklist item Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading