Skip to content
Snippets Groups Projects

Make lacc argument mandatory for fortran_tools

Merged Yen-Chen Chen requested to merge make_lacc_mandatory into master

What is the new feature

Make lacc mandatory.

How is it implemented

With the changes in https://gitlab.dkrz.de/icon/icon-mpim/-/merge_requests/342, https://gitlab.dkrz.de/art/art/-/merge_requests/96, and https://gitlab.dkrz.de/jsbach/jsbach/-/merge_requests/165, the lacc argument in all fortran_tools functions should be added explicitly.
This MR makes sure that in the future, an error will pop up if lacc is not passed.

Mandatory steps before review

  • Gitlab CI passes (Hint: use make format for linting)
  • New feature is covered by additional unit tests
  • Mark the merge request as ready by removing Draft:

Mandatory steps before merge

  • Test coverage does not decrease
  • Reviewed by a maintainer
  • Incorporate review suggestions
  • Prior to merging, please remove any boilerplate from the MR description, retaining only the Please describe your feature in a couple of words and describe important implementation details of the feature section to maintain
  • Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)

You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!

Edited by Yen-Chen Chen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marek Jacob
  • Marek Jacob
  • Yen-Chen Chen added 1 commit

    added 1 commit

    Compare with previous version

  • Yen-Chen Chen added 2 commits

    added 2 commits

    • 4000596d - Remove error message when compile without OpenACC
    • c6f94479 - Remove unused assertion error test

    Compare with previous version

  • Marek Jacob approved this merge request

    approved this merge request

  • Yen-Chen Chen resolved all threads

    resolved all threads

  • Jonas Jucker approved this merge request

    approved this merge request

  • Yen-Chen Chen marked the checklist item Test coverage does not decrease as completed

    marked the checklist item Test coverage does not decrease as completed

  • Yen-Chen Chen marked the checklist item Reviewed by a maintainer as completed

    marked the checklist item Reviewed by a maintainer as completed

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading