Remove unused signal module
This might not make things work on macOS (we don't seem to be using the functionality in ICON anyway) but at least this should leave no undefined symbols in the library:
Undefined symbols for architecture arm64:
"_fedisableexcept", referenced from:
_signal_trap in util_signal.c.o
"_feenableexcept", referenced from:
_signal_trap in util_signal.c.o
ld: symbol(s) not found for architecture arm64
And I don't think that it would be different for an Intel-based Mac.
Merge request reports
Activity
- Resolved by Yen-Chen Chen
This was also something confusing to me. This code does not work on my Macbook. But it was copied directly from the ICON main repo, so I thought it was a version problem and might work on some MacOS systems. If it is a dead code, maybe we can remove the whole thing (the part for MacOS)?
assigned to @b382190
- Resolved by Yen-Chen Chen
The subroutine is still used in the main programs of DACE. See https://gitlab.dkrz.de/dwd-sw/dace-icon-interface/-/issues/3
added 34 commits
-
9912bf4a...3eec3353 - 31 commits from branch
master
- b155d54e - Avoid unresolved symbols on macOS
- eb4b391e - Resolve unused signal code for MAC OS
- 48e3eb3b - Remove mo_util_signal
Toggle commit list-
9912bf4a...3eec3353 - 31 commits from branch
mentioned in commit faf85bc7
mentioned in merge request !60 (closed)