Skip to content
Snippets Groups Projects

Remove cmake version check in CMakeLists.txt

Closed Ulrich Blahak requested to merge fix/remove-cmake-version-check into master

What is the new feature

No change of any fortran code, just removal of the cmake version check in CMakeLists.txt. It seems no longer necessary due to past changes related to the renaming of f90 suffixes to F90.

How is it implemented

Version check commented out and added a code line

cmake_policy(SET CMP0048 NEW)

which seems to be required if using an older cmake version as 3.18

Mandatory steps before review

  • Gitlab CI passes (Hint: use make format for linting)
  • New feature is covered by additional unit tests
  • Mark the merge request as ready by removing Draft:

Mandatory steps before merge

  • Test coverage does not decrease
  • Reviewed by a maintainer
  • Incorporate review suggestions
  • Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)

You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!

Edited by Ulrich Blahak

Merge request reports

Merge request pipeline #55269 passed

Merge request pipeline passed for 945b74a1

Test coverage 44.40% (0.00%) from 1 job

Closed by Ulrich BlahakUlrich Blahak 1 year ago (Jan 10, 2024 3:41pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading