Fix falsely deleted nml variable
What is the bug
The variable nnml
is falsely deleted in !94 (merged). Which causes error in dace that uses nnml
from mo_namelist
.
How do you fix it
Add back the variable.
How urgent is the bugfix
-
I need it as soon as possible -
I can wait for a couple of days -
None of my current codes is directly affected
Mandatory steps before review
-
Gitlab CI passes (Hint: use make format
for linting) -
Bugfix is covered by additional unit tests -
Mark the merge request as ready by removing Draft:
Mandatory steps before merge
-
Test coverage does not decrease -
Reviewed by a maintainer -
Incorporate review suggestions -
Prior to merging, please remove any boilerplate from the MR description, retaining only the What is the bug and How do you fix it section to maintain -
Remember to edit the commit message and select the proper changelog category (feature/bugfix/other)
You are not supposed to merge this request by yourself, the maintainers of fortan-support take care of this action!
Edited by Yen-Chen Chen
Merge request reports
Activity
requested review from @b381001
assigned to @b382190
added bug ready for review labels
removed ready for review label
- Resolved by Yen-Chen Chen
LGTM
added 1 commit
- 31b6b4c8 - Remove duplicated public variable (typo nml)
requested review from @b381001 and removed approval
added ready for review label
mentioned in commit cde3e258
Please register or sign in to reply