accepted
merge request
!1
"Make the Plot Healpix 2d work as Freva Plugin"
at
freva / plugins4freva / ORCESTRA Campaign / Plot Healpix 2d
-
7bbff534 · Merge branch 'add-changes' into 'main'
- ... and 5 more commits. Compare e425eecf...7bbff534
commented on
merge request !1
"Make the Plot Healpix 2d work as Freva Plugin"
at
freva / plugins4freva / ORCESTRA Campaign / Plot Healpix 2d
I got offline LGTM from @k204230
commented on
merge request !1
"Make the Plot Curtain plugin work as Freva plugin"
at
freva / plugins4freva / ORCESTRA Campaign / Plot Curtain
LGTM
-
116c20c2 · Merge branch 'add-changes' into 'main'
- ... and 9 more commits. Compare 40907093...116c20c2
accepted
merge request
!1
"Make the Plot Curtain plugin work as Freva plugin"
at
freva / plugins4freva / ORCESTRA Campaign / Plot Curtain
commented on
merge request !1
"Make the Plot Healpix 2d work as Freva Plugin"
at
freva / plugins4freva / ORCESTRA Campaign / Plot Healpix 2d
Just a question: How come there are already changes?
commented on
merge request !1
"Make the Plot Healpix 2d work as Freva Plugin"
at
freva / plugins4freva / ORCESTRA Campaign / Plot Healpix 2d
If you don't lint then you can remove this.
commented on
merge request !1
"Make the Plot Healpix 2d work as Freva Plugin"
at
freva / plugins4freva / ORCESTRA Campaign / Plot Healpix 2d
I am not a fan of executing code on import. Could you wrap the code that gets excecuted into a function or multiple functions and then use a if name...