Should we have a quick meeting about your plans? I would be curious to know what specifically you had in mind.
Martin Bergemann (df8f7d34) at 15 Mar 18:44
Martin Bergemann (4af3e103) at 15 Mar 18:44
Merge branch 'add-subregion' into 'main'
... and 12 more commits
Hmm, I didn't get any notification.
patched here so it still can handle variable names extracted from the metadata that contain caps:
@cached_property
def variables(self) -> list[str]:
"""The variables as they are stored in the dataset."""
return [
var
for var in self._dataset.data_vars
if (var in self._variables) or (var.lower() in self._variables) <---
]
Martin Bergemann (df8f7d34) at 15 Mar 18:27
Merge branch 'caps_variables' into 'add-subregion'
... and 2 more commits
patched here so it still can handle variable names extracted from the metadata that contain caps:
@cached_property
def variables(self) -> list[str]:
"""The variables as they are stored in the dataset."""
return [
var
for var in self._dataset.data_vars
if (var in self._variables) or (var.lower() in self._variables) <---
]
Yes of course, having discussions is good!
Great ideas. Though I am not sure about, whether cookie-cutter is what we want here because it would just add too much boilerplate. I am also not sure whether we really need API documentation. At the end of the day, people use the plugin as a stand-alone tool, cli like if you want. So only documenting what this thing does and how stuff is calculated should be fine. The documentation of the options, is done by freva.
Check out the conda-forge guidlines: https://conda-forge.org/docs/maintainer/adding_pkgs/#dev-contribute-pkgs