Nicolai Stange authored Jun 29, 2016 and Hendryk Bockelmann committed Oct 06, 2016

Automake is capable of handling the uninstallations of files it knows about
by itself and thus, the uninstall-local target in src/Makefile is
superfluous. Remove it.

Nicolai Stange authored Jun 29, 2016 and Hendryk Bockelmann committed Oct 06, 2016

CLEANFILES is way easier than writing custom clean-local hooks. Employ it.

Nicolai Stange authored Jun 29, 2016 and Hendryk Bockelmann committed Oct 06, 2016

sct.h is generated at build time. Add it to BUILT_SOURCES to ensure that
it gets built before anything else unconditionally.

Nicolai Stange authored Jun 29, 2016 and Hendryk Bockelmann committed Oct 06, 2016

The sct.h header is generated at build time and depends on the
configuration. Do not include it in 'make dist' by putting it into
the nodist_pkginclude_HEADERS variable.

Furthermore, remove the *_SOURCES dependencies on sct.h from the programs
in tests/ -- the Automake manual explicitly says that this doesn't work
(section 9.4.1 Built Sources Example) and they cause sct.h to be included
in the 'make dist' tarball.

Nicolai Stange authored Jun 29, 2016 and Hendryk Bockelmann committed Oct 06, 2016

Currently, the way src/sct.h is generated forbids out-of-tree builds.

Fix this by giving the util/gen_public_header.pl script full paths
to the source headers, i.e. prefix them by $(srcdir).

For the tests directory, add -I $(top_builddir)/src to its CPPFLAGS in
order to make the tests compilations find the sct.h places in the build
directory now.

Nicolai Stange authored Jun 29, 2016 and Hendryk Bockelmann committed Oct 06, 2016

Currently, configure constructs a $SETUPTYPE string based on the selected
configuration and appends that to installation prefix as given by --prefix.

This behaviour is not only unusual, but limits the user to completely
determine the final installation path.

Abandon it. Namely,
- purge the --with-mpitype option from configure,
- do not construct a $SETUPTYPE string,
- purge any reference to $SETUPTYPE from the Makefile.am's.

Additionally, in order to avoid name clashs in the case of
--enable-fakelib, install the "real" sct headers into $pkgincludedir, e.g.
$prefix/include/sct, and the fake ones into a directory named "nosct"
thereunder. Rename the fake libsct.la to libnosct.la.

The above changes render the install-all make target, which reconfigures
and rebuilds in all combinations of w/ and w/o OpenMP and MPI,
disfunctional. Functionality of that kind is better preserved in some
user defined wrapper scripts around the build process anyway and thus,
purge the install-all make target.

Finally, adapt the pkgconfig/sct.pc.in to properly reflect the changes.

Automake is capable of handling the uninstallations of files it knows about
by itself and thus, the uninstall-local target in src/Makefile is
superfluous. Remove it.

CLEANFILES is way easier than writing custom clean-local hooks. Employ it.

sct.h is generated at build time. Add it to BUILT_SOURCES to ensure that
it gets built before anything else unconditionally.

The sct.h header is generated at build time and depends on the
configuration. Do not include it in 'make dist' by putting it into
the nodist_pkginclude_HEADERS variable.

Furthermore, remove the *_SOURCES dependencies on sct.h from the programs
in tests/ -- the Automake manual explicitly says that this doesn't work
(section 9.4.1 Built Sources Example) and they cause sct.h to be included
in the 'make dist' tarball.

Currently, the way src/sct.h is generated forbids out-of-tree builds.

Fix this by giving the util/gen_public_header.pl script full paths
to the source headers, i.e. prefix them by $(srcdir).

For the tests directory, add -I $(top_builddir)/src to its CPPFLAGS in
order to make the tests compilations find the sct.h places in the build
directory now.

Currently, configure constructs a $SETUPTYPE string based on the selected
configuration and appends that to installation prefix as given by --prefix.

This behaviour is not only unusual, but limits the user to completely
determine the final installation path.

Abandon it. Namely,
- purge the --with-mpitype option from configure,
- do not construct a $SETUPTYPE string,
- purge any reference to $SETUPTYPE from the Makefile.am's.

Additionally, in order to avoid name clashs in the case of
--enable-fakelib, install the "real" sct headers into $pkgincludedir, e.g.
$prefix/include/sct, and the fake ones into a directory named "nosct"
thereunder. Rename the fake libsct.la to libnosct.la.

The above changes render the install-all make target, which reconfigures
and rebuilds in all combinations of w/ and w/o OpenMP and MPI,
disfunctional. Functionality of that kind is better preserved in some
user defined wrapper scripts around the build process anyway and thus,
purge the install-all make target.

Finally, adapt the pkgconfig/sct.pc.in to properly reflect the changes.